Skip to content

Release 0.23.2 - #347

Merged
dwoz merged 1 commit into
mainfrom
auto-update-versions
Nov 17, 2026
Merged

dwoz merged 1 commit into
mainfrom
auto-update-versions

Conversation

@salt-pr-bot

@salt-pr-bot salt-pr-bot Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Automated version bump for Python and bundled dependencies.

This PR will be merged automatically once CI passes, which will
trigger the release workflow.

@dwoz
dwoz merged commit 885d0a7 into main Nov 17, 2026
dwoz added a commit that referenced this pull request Nov 19, 2026
* Trigger auto-merge on approval, not just on CI completion

The prior revision only fired on ``workflow_run`` of "Pull Request or
Push" completing.  When CI went green before a human had approved, the
one chance to run the auto-merge step came and went with zero approvals
recorded, and the PR then sat open indefinitely -- the approval event
alone didn't re-trigger anything.  This bit us on PR #347 (Release
0.23.2) which had green CI for two days before approval; after approval
it still had to be merged by hand.

Add a ``pull_request_review`` trigger and a shared resolution step that
figures out the PR + head SHA regardless of which event fired.  The
merge step now:

* re-verifies the ``automated-update`` label on the PR
* requires at least one approving review (unchanged)
* requires every status check to be ``COMPLETED`` with conclusion in
  ``{SUCCESS, SKIPPED, NEUTRAL}`` -- the previous version relied on the
  ``workflow_run`` ``if`` guard for this, which doesn't help when the
  entry point is a review event

So either ordering now unblocks: CI-then-approval (workflow_run fires,
approval already in place) or approval-then-CI (pull_request_review
fires, waits for CI, next workflow_run completion then merges).

The merge is still ``--squash --delete-branch`` and the App token path
is unchanged.

* Fix pre-commit libxml2 install on Ubuntu 26.04

ubuntu-latest rolled to 26.04 "resolute" in Nov 2026, which dropped the
bare ``libxml2`` runtime package from the archive.  Every pre-commit CI
run since then fails during ``apt-get install`` with::

    E: Package 'libxml2' has no installation candidate

breaking the pre-commit gate for every open PR.  ``libxml2-dev`` is
still in resolute and pulls the current ``libxml2``-ABI runtime SONAME
package in transitively, so dropping just the bare ``libxml2`` entry
from the install list is enough.  Rest of the package list is
unchanged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant