🛡️ Sentinel: [CRITICAL] Fix framework secrets leakage via execa - #419
🛡️ Sentinel: [CRITICAL] Fix framework secrets leakage via execa#419google-labs-jules[bot] wants to merge 3 commits into
Conversation
Environment variable redaction via `sanitizeEnvironment` is bypassed when calling `execa` without `extendEnv: false`, because it defaults to `true` and re-injects sensitive secrets from `process.env`. This commit fixes `src/core/tools/capability/runner.ts` and `src/cli/authorization/non-interactive.ts` to properly pass `extendEnv: false` while merging custom `env` with `process.env` so that `PATH` is not stripped.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Environment variable redaction via `sanitizeEnvironment` is bypassed when calling `execa` without `extendEnv: false`, because it defaults to `true` and re-injects sensitive secrets from `process.env`. This commit fixes `src/core/tools/capability/runner.ts` and `src/cli/authorization/non-interactive.ts` to properly pass `extendEnv: false` while merging custom `env` with `process.env` so that `PATH` is not stripped. This also includes the linting fixes applied automatically by eslint/oxfmt.
Environment variable redaction via `sanitizeEnvironment` is bypassed when calling `execa` without `extendEnv: false`, because it defaults to `true` and re-injects sensitive secrets from `process.env`. This commit fixes `src/core/tools/capability/runner.ts` and `src/cli/authorization/non-interactive.ts` to properly pass `extendEnv: false` while merging custom `env` with `process.env` so that `PATH` is not stripped. This also includes the linting fixes applied automatically by eslint/oxfmt, and respects architectural boundaries by importing `sanitizeEnvironment` through the facade in CLI code.
🚨 Severity: CRITICAL
💡 Vulnerability: Environment variable redaction via
sanitizeEnvironmentis bypassed when callingexecabecause it defaults toextendEnv: true, effectively re-injecting sensitive secrets fromprocess.env.🎯 Impact: Framework secrets such as
SALMONLOOP_API_KEYmay be leaked to subprocesses running untrusted commands.🔧 Fix: Ensure
envis explicitly sanitized usingsanitizeEnvironment(merging withprocess.envto retainPATH) andextendEnv: falseis passed to allexecainvocations to disable auto-merging of the unsanitized environment.✅ Verification: Ran formatting and full test suite successfully.
PR created automatically by Jules for task 10851826948655853487 started by @YoungSx