Skip to content

🛡️ Sentinel: [HIGH] Fix quoted secret redaction bypass #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YoungSx merged 2 commits into from
Aug 31, 2026
Merged

🛡️ Sentinel: [HIGH] Fix quoted secret redaction bypass #414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa957ca
🛡️ Sentinel: [HIGH] Fix quoted secret redaction bypass
google-labs-jules[bot] Aug 30, 2026
0045d16
Merge remote-tracking branch 'origin/main' into probe-414
claude Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .jules/sentinel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,8 @@
**Vulnerability:** execa re-injects unsanitized process.env by default when extendEnv is true.
**Learning:** Using sanitizeEnvironment() but missing extendEnv: false defeated the purpose.
**Prevention:** Always explicitly set extendEnv: false when passing a sanitized environment object to execa.

## 2026-08-30 - Fix Quoted Secret Redaction Bypass
**Vulnerability:** The redaction regex `KV_PATTERN` failed to match and redact quoted secret values (e.g., `password="mysecret"`), potentially leaking credentials in audit logs.
**Learning:** Regular expressions for sanitizing key=value pairs must account for quoted values by explicitly including `"[^"]*"` and `'[^']*'` in the matching group.
**Prevention:** When writing regex for secrets matching, always include patterns for both quoted and unquoted strings to prevent simple bypasses.
3 changes: 2 additions & 1 deletion src/core/security/redaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,8 @@ const SIMPLE_PATTERNS: Array<RegExp> = [
/\b(?:\d{1,3}\.){3}\d{1,3}\b/g,
];

const KV_PATTERN = /(\b(?:token|secret|password|api[_-]?key)\b\s*[:=]\s*)([^\s,'"]+)/gi;
const KV_PATTERN =
/(\b(?:token|secret|password|api[_-]?key)\b\s*[:=]\s*)("[^"]*"|'[^']*'|[^\s,'"]+)/gi;
const QUERY_PATTERN = /([?&](?:token|secret|password|api_key|apikey)=)([^&\s]+)/gi;

compiledPatterns = [...SIMPLE_PATTERNS];
Expand Down
Loading