fix(cdc-acm): expose serial state notifications - #37
Merged
Conversation
|
|
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Oscariremma
force-pushed
the
fix/cdc-acm-serial-state
branch
from
July 29, 2026 14:42
9078bb6 to
72204ea
Compare
Owner
|
Thanks for the PR — merged. Published as android-usb-serial 0.1.1 (plugin 3.0.2). Follow-up on main: malformed / unrelated interrupt frames are skipped instead of killing the notification reader (same approach as usb-serial-for-android), plus |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CDC ACM devices can report modem-state changes through an interrupt endpoint on the control interface.
This endpoint was previously left unread, which can cause some devices to stop processing subsequent USB traffic.
This PR reads CDC SERIAL_STATE notifications and exposes the reported carrier detect, data set ready, and ring indicator values through modem_status().
CTS remains unsupported because it is not part of the CDC serial-state notification.
Devices without a notification endpoint continue to return the default modem status.
Summary by cubic
Read CDC ACM interrupt-IN serial-state notifications and expose DCD, DSR, and RI via
modem_status(). Also consume and manage the control interrupt endpoint to prevent stalls and clean up on failure or close.New Features
modem_status()from CDC SERIAL_STATE notifications; CTS not supported.Bug Fixes
Written for commit 72204ea. Summary will update on new commits.