Skip to content

Refactor SSE, NDJSON, and gRPC streaming onto a shared stdout driver#658

Merged
ryanfowler merged 1 commit into
mainfrom
refactor-streaming-driver
May 29, 2026
Merged

Refactor SSE, NDJSON, and gRPC streaming onto a shared stdout driver#658
ryanfowler merged 1 commit into
mainfrom
refactor-streaming-driver

Conversation

@ryanfowler
Copy link
Copy Markdown
Owner

Summary

  • Added a small formatter callback driver in src/http/mod.rs to centralize decoded reads, clipboard capture, byte counting, trailer extraction, and stdout flushing.
  • Kept SSE, NDJSON, and gRPC parsing logic separate behind formatter-specific callbacks and local state objects.
  • Reused the same trailer snapshot helper across the other streaming paths.
  • Updated AGENTS.md to document the new streaming ownership boundary.

Testing

  • cargo fmt
  • cargo clippy --locked --all-targets --all-features -- -D warnings
  • Focused Rust tests for formatted streaming paths passed, including SSE, NDJSON, gRPC, and split-chunk NDJSON coverage.

@ryanfowler ryanfowler merged commit dd7c51e into main May 29, 2026
4 checks passed
@ryanfowler ryanfowler deleted the refactor-streaming-driver branch May 29, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant