ci: pin Tiny Dancer build toolchain to 1.97.0 to fix aarch64-musl zig link drift (#900) - #934
Draft
ruvnet wants to merge 1 commit into
Draft
ci: pin Tiny Dancer build toolchain to 1.97.0 to fix aarch64-musl zig link drift (#900)#934ruvnet wants to merge 1 commit into
ruvnet wants to merge 1 commit into
Conversation
… link (#900) Stable 1.98.0 (2026-08-18) began emitting --fix-cortex-a53-843419 (the Cortex-A53 erratum workaround) for aarch64-unknown-linux-musl. Zig's linker rejects the flag as an unsupported linker arg — verified locally against zig 0.13.0, 0.14.1, 0.15.2, and 0.16.0, so bumping zig cannot fix this today. The failure reproduces with a minimal cdylib link (rustc 1.98.0 + zig cc -target aarch64-linux-musl) and disappears on 1.97.0 with the same zig, so 1.97.0 is the newest stable whose aarch64-musl target spec predates the flag. Pinning the toolchain (zig was already pinned at 0.13.0) is what #900 prescribed: both sides of the cross-compile move together instead of drifting apart silently, as they did for the three weeks this path-filtered workflow did not run. Fixes #900. Co-Authored-By: claude-flow <ruv@ruv.net> Claude-Session: https://claude.ai/code/session_01L5ffi8NiKAQNabK3D5t2gK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The separate CI PR that #900 asked for.
Build Tiny Dancer linux-arm64-muslfails on every PR touching tiny-dancer paths with:Fixes #900.
Root cause, pinned down empirically
#900 diagnosed rust-toolchain/zig drift and offered two candidate fixes (pin rustc, or bump zig). Both were tested locally before choosing:
-Wl,--fix-cortex-a53-843419was run against zig 0.13.0, 0.14.1, 0.15.2, and 0.16.0 — every version rejects the flag with the sameunsupported linker argerror, so no available zig release fixes this.rustc 1.98.0+zig cc -target aarch64-linux-muslas linker,-C target-feature=-crt-static), and the same link stops emitting the flag on 1.97.0 with the same zig. That timeline matches the workflow's last green run on 2026-08-03 (1.97-era stable) and the failures starting 2026-08-22.So the fix is the other half of #900's recommendation: pin
toolchain: "1.97.0"next to the existingzig 0.13.0pin, so both sides of the cross-compile move together deliberately instead of drifting apart silently while the path-filtered workflow doesn't run. The pin carries a comment explaining exactly why and what to re-check when bumping it.Change
One file:
.github/workflows/build-tiny-dancer.yml,toolchain: stable→toolchain: "1.97.0"plus the explanatory comment. No other workflow combines zig with an aarch64-musl target, so this is the whole blast radius.Validation
unsupported linker arg: --fix-cortex-a53-843419, failing in a third-party dep before first-party code).Note: the
pull_requestpath filter for this workflow doesn't include the workflow file itself, so this PR won't show the Tiny Dancer matrix in its own checks; the fix takes effect on tiny-dancer-touching PRs (e.g. #933) once merged.🤖 Generated with claude-flow
https://claude.ai/code/session_01L5ffi8NiKAQNabK3D5t2gK
Generated by Claude Code