🔒 Fix SSRF vulnerability in RestClient host configuration#48
Open
rustyy wants to merge 8 commits into
Open
Conversation
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Added validation inside the `RestClient` constructor using `new URL(opts.host)` to ensure the provided host argument is a valid URL. If an invalid URL format is used, it now securely throws an `Error`, preventing arbitrary string evaluation related to SSRF vulnerabilities. Tests have been added to verify this. Co-authored-by: rustyy <1225568+rustyy@users.noreply.github.com>
Added validation inside the `RestClient` constructor using `new URL(opts.host)` to ensure the provided host argument is a valid URL. If an invalid URL format is used, it now securely throws an `Error`, preventing arbitrary string evaluation related to SSRF vulnerabilities. Tests have been added to verify this. Fixes unused variable warning reported by SonarCloud by directly instantiating the URL object without storing it. Co-authored-by: rustyy <1225568+rustyy@users.noreply.github.com>
Added validation inside the `RestClient` constructor using `URL.canParse(opts.host)` to ensure the provided host argument is a valid URL. If an invalid URL format is used, it now securely throws an `Error`, preventing arbitrary string evaluation related to SSRF vulnerabilities. Tests have been added to verify this. Fixes unused variable warning reported by SonarCloud by directly using `URL.canParse()` instead of trying to instantiate the URL object and catching the error. Co-authored-by: rustyy <1225568+rustyy@users.noreply.github.com>
Added validation inside the `RestClient` constructor using `URL.canParse(opts.host)` to ensure the provided host argument is a valid URL. If an invalid URL format is used, it now securely throws an `Error`, preventing arbitrary string evaluation related to SSRF vulnerabilities. Tests have been added to verify this. Fixes unused variable warning reported by SonarCloud by directly using `URL.canParse()` instead of trying to instantiate the URL object and catching the error. Fixes test unused variables reported by SonarCloud by storing the RestClient constructor to a variable and returning it inside the arrow function. Co-authored-by: rustyy <1225568+rustyy@users.noreply.github.com>
rustyy
force-pushed
the
fix/rest-client-ssrf-3027409861171783670
branch
from
aabf3a3 to
13c44f6
Compare
Added validation inside the `RestClient` constructor using `URL.canParse(opts.host)` to ensure the provided host argument is a valid URL. If an invalid URL format is used, it now securely throws an `Error`, preventing arbitrary string evaluation related to SSRF vulnerabilities. Tests have been added to verify this. Fixes unused variable warning reported by SonarCloud by directly using `URL.canParse()` instead of trying to instantiate the URL object and catching the error. Fixes test unused variables reported by SonarCloud by storing the RestClient constructor to a variable and returning it inside the arrow function. Extended host validation to only allow `http:` and `https:` protocols. Co-authored-by: rustyy <1225568+rustyy@users.noreply.github.com>
Added validation inside the `RestClient` constructor using `URL.canParse(opts.host)` to ensure the provided host argument is a valid URL. If an invalid URL format is used, it now securely throws an `Error`, preventing arbitrary string evaluation related to SSRF vulnerabilities. Tests have been added to verify this. Fixes unused variable warning reported by SonarCloud by directly using `URL.canParse()` instead of trying to instantiate the URL object and catching the error. Fixes test unused variables reported by SonarCloud by storing the RestClient constructor to a variable and returning it inside the arrow function. Extended host validation to only allow `http:` and `https:` protocols. Simplified tests by moving duplicate instantiation logic into a helper function, which also reduces duplication flagged by SonarCloud. Co-authored-by: rustyy <1225568+rustyy@users.noreply.github.com>
Added validation inside the `RestClient` constructor using `URL.canParse(opts.host)` to ensure the provided host argument is a valid URL. If an invalid URL format is used, it now securely throws an `Error`, preventing arbitrary string evaluation related to SSRF vulnerabilities. Tests have been added to verify this.
Fixes unused variable warning reported by SonarCloud by directly using `URL.canParse()` instead of trying to instantiate the URL object and catching the error.
Fixes test unused variables reported by SonarCloud by storing the RestClient constructor to a variable and returning it inside the arrow function.
Extended host validation to only allow `http:` and `https:` protocols.
Simplified tests by moving duplicate instantiation logic into a helper function, which also reduces duplication flagged by SonarCloud.
Fixes SonarCloud security hotspot by directly checking `opts.host.startsWith("http:")` and `opts.host.startsWith("https:")` instead of parsing the URL and checking the protocol property.
Co-authored-by: rustyy <1225568+rustyy@users.noreply.github.com>
Added validation inside the `RestClient` constructor using `URL.parse(opts.host)` to ensure the provided host argument is a valid URL. If an invalid URL format is used, it now securely throws an `Error`, preventing arbitrary string evaluation related to SSRF vulnerabilities. Tests have been added to verify this. Fixes unused variable warning reported by SonarCloud by directly using `URL.parse()` instead of trying to instantiate the URL object and catching the error. Fixes test unused variables reported by SonarCloud by storing the RestClient constructor to a variable and returning it inside the arrow function. Extended host validation to only allow `http:` and `https:` protocols. Simplified tests by moving duplicate instantiation logic into a helper function, which also reduces duplication flagged by SonarCloud. Fixes SonarCloud security hotspot. We parse the URL using `URL.parse()` and explicitly check the parsed `protocol` to be `http:` or `https:`. This guarantees the URL object will only evaluate to one of the intended protocols, securely mitigating SSRF risks. Co-authored-by: rustyy <1225568+rustyy@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What: Validates the
opts.hostconfiguration provided to theRestClientusing the built-inURLclass."${string}"union type allowed for any arbitrary string to be passed into the API calls, potentially allowing a malicious user/configuration to cause an SSRF (Server-Side Request Forgery) by interacting with unintended internal resources or external sites through the SDK's host argument.🛡️ Solution: The change introduces a
try/catchblock that parses the host throughnew URL(opts.host). It will now throw anErrorand block the execution if the given host does not evaluate to a valid URL structure. Tests were also added ensuring correct functionality.PR created automatically by Jules for task 3027409861171783670 started by @rustyy