feat: accelerated turn timeout for offline players#133
Merged
Conversation
When the current human player is offline, startTurn shortens the turn to a grace window (game.OfflineGraceDuration, 10s) instead of the full 60s, so an abandoned game advances and cleans up quickly (kick after ~30s vs ~180s). - presence is now keyed by player_id (string) instead of uid; ping refreshes by claims.PlayerID — the identity the game FSM uses. - game gains an OnlineChecker interface + WithOnlineChecker option; startTurn only ever reduces a human player's turn, never bots or custom durations. - cmd wires a presenceChecker adapter (*presence.Service + ctx timeout). - tests: offline player times out within grace; online keeps the full turn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the current human player is offline, startTurn shortens the turn to a grace window (game.OfflineGraceDuration, 10s) instead of the full 60s, so an abandoned game advances and cleans up quickly (kick after ~30s vs ~180s).