Refactor/fiveletters slice#128
Merged
Merged
Conversation
Balda forbids proper nouns. The dictionary currently loads 253 leading- uppercase keys (Диана, Аллах, Земля...); a capitalized word can even be picked as the initial board word, breaking lowercase lookups for words that reuse its cells. Failing test asserts no leading-uppercase keys.
Skip leading-uppercase keys in NewDictionary so proper nouns (Диана, Аллах, Земля) are neither playable nor selectable as the initial board word. Their lowercase common-noun homographs (парка, земля, север) are separate keys and remain. Removes the rare case where a capitalized initial word broke lookups.
The map had sequential integer keys — effectively a slice with overhead. Use append instead of a manual counter, which also avoids a latent bug where the counter reset per decoded JSON object would have overwritten keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.