Repository navigation
Conversation
|
So I would push e.g. I'm not sure about it. Although I do always tag releases (if I don't forget) they aren't immutable in git. I'm also not sure if everybody with write access to the repo has publish permissions, which this would make the same thing. In general I'm fine with the current process, it's not automated at all, but I don't release very often anyway so I'm not bothered by it. |
|
More specifically, after you push a tag, CI will just do Right now, everyone with write access to the repo could indeed publish something. If you don't like that all
I understand that, but the Rust infra team decided on a policy to have all I'm happy to change the publishing story however you want, but it has to happen from CI. We can publish after a push to |
I'm not convinced this is the right flow for publishing to be honest. I don't consider it more secure than doing it manually, certainly more trusted (as access to publishing is actually given to more people).
I'll think about this a bit more, but I don't really have that much time to dedicate to this. |
It's not necessarily about being more secure, but about having an audit trail. If you can only publish from CI, we can get a lot of all historical publishes from this CI, including who performed them, and exactly what code was published. |
Thomasdezeeuw
left a comment
There was a problem hiding this comment.
I've been thinking about this some more and I think it's ok to go into this direction. Ideally though we can limit the group of users that actually publish the crate to smaller group than people who can commit/write to the repo.
@Kobzol do you know if this is possible?
Alternative maybe we can remove some people with maintain access who haven't contributed in a while in https://github.com/Kobzol/team/blob/4d8702cbec67e17df7763da9db0ea9114da1896f/repos/rust-lang/socket2.toml ?
Thanks for doing this @Kobzol
|
It is possible to the extent of creating a separate team, i.e. a Regarding the access, we should ideally remove all access of individuals from all our repos. So I'm happy to remove the access of individuals here. |
|
Oh, the individual access has been removed already, you posted an outdated commit. This is the current one: https://github.com/kobzol/team/blob/3fb7c433b7c2c5801e718438c23704c55f88febb/repos/rust-lang/socket2.toml |
So that we can track the crate in the team DB.
Currently, this PR configures CI to publish the
socket2when a tag is pushed to this repo. Let me know if you want to use a different mechanism.Companion PR: rust-lang/team#2944