Skip to content

SockAddr::path_len doesn't bound the length by sun_path: as_pathname panics since #691, as_abstract_namespace slices past it #694

Open

Description

@marius-momeu

SockAddr::path_len computes the path length from self.len() without bounding it by sun_path's 108 bytes. SockAddrStorage::view_as's documentation example copies a received sockaddr_storage whole and passes size_of::<sockaddr_storage>() as the length, and for an AF_UNIX address built that way len is 126:

use std::mem::size_of;
use socket2::{SockAddr, SockAddrStorage, socklen_t};

fn main() {
    let mut received: libc::sockaddr_storage = unsafe { std::mem::zeroed() };
    let un = unsafe { &mut *(&mut received as *mut _ as *mut libc::sockaddr_un) };
    un.sun_family = libc::AF_UNIX as libc::sa_family_t;
    un.sun_path[1] = b'a' as libc::c_char; // abstract name; set sun_path[0] instead for a pathname
    let mut storage = SockAddrStorage::zeroed();
    unsafe { *storage.view_as::<libc::sockaddr_storage>() = received };
    let addr = unsafe { SockAddr::new(storage, size_of::<libc::sockaddr_storage>() as socklen_t) };
    println!("{}", addr.as_abstract_namespace().unwrap().len()); // 125
}

cargo +nightly miri run:

error: Undefined Behavior: trying to retag from <736> for SharedReadOnly permission at alloc263[0x6e], but that tag does not exist in the borrow stack for this location
   --> src/sys/unix.rs:966:13
help: <736> was created by a SharedReadOnly retag at offsets [0x2..0x6e]

With un.sun_path[0] = b'a' and as_pathname(), natively and under Miri:

thread 'main' panicked at src/sys/unix.rs:944:19:
index out of bounds: the len is 108 but the index is 125

This was run on master at b6c3b8e with libc 0.2.191 and rustc 1.102.0-nightly (2026-11-12), on x86_64-unknown-linux-gnu.

A possible fix is to bound the length in path_len:

let len = (self.len() as usize - offset_of_path(storage)).min(storage.sun_path.len());

I tested it on master: both cases then return 107 bytes, natively and under Miri, and cargo test --features all passes.

Found by Crustify, an experimental UB/soundness auditing agent developed at UC Berkeley and running on Claude Opus 5.5, then manually reviewed and independently reproduced.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions