Skip to content

feat(cli/rustup-mode): add rustup ci subcommand - #5021

Draft
rami3l wants to merge 1 commit into
rust-lang:mainfrom
rami3l:x/rustup-ci-subcmd
Draft

feat(cli/rustup-mode): add rustup ci subcommand#5021
rami3l wants to merge 1 commit into
rust-lang:mainfrom
rami3l:x/rustup-ci-subcmd

Conversation

@rami3l

@rami3l rami3l commented Aug 18, 2026

Copy link
Copy Markdown
Member

Part of #5011.

This first version has implemented a few main subcommands:

Footnotes

  1. Taken from @r7kamura's solution (https://github.com/r7kamura/rust-problem-matchers/blob/7e46a19e8d2f3a44f97b551aee14a7b3cc18fcd0/.github/matchers.json) since it seems to be the most comprehensive of all.

Comment thread src/cli/ci/base.env Outdated
CARGO_PROFILE_DEV_DEBUG=0
CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
CARGO_TERM_COLOR=always
CARGO_UNSTABLE_SPARSE_REGISTRY=true

@rami3l rami3l Aug 18, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/cli/ci/base.env Outdated
@@ -0,0 +1,6 @@
CARGO_INCREMENTAL=0
CARGO_PROFILE_DEV_DEBUG=0
CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse

@rami3l rami3l Aug 18, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weihanglo Is it safe to always set this flag similarly to #5021 (comment)?

View changes since the review

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For incremental I think so. Cargo shipped a similar thing recently: rust-lang/cargo#17220

For profile dev debug, Cargo will have a new debug profile and we planned to turn off debug for dev profile:
rust-lang/cargo#17214. So, the direction looks pretty aligned.

For registry protocol, we may want to test if there is any version treating it as a hard error if not recognized. I believe no but worth a double check.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably could test pre-1.61 1.61 to 1.68, and post 1.68

@r7kamura

Copy link
Copy Markdown

Feel free to use my solution for whatever you need👍
It actually came from the issue and PR below, so check 'em out if you're interested:

@rami3l
rami3l force-pushed the x/rustup-ci-subcmd branch 2 times, most recently from d5a9f89 to 5917940 Compare August 18, 2026 14:10
@rami3l

rami3l commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

@r7kamura Thanks a lot for the extra context! I've made you the co-author for this commit as a sign of appreciation.

@rami3l
rami3l marked this pull request as ready for review August 19, 2026 10:56
Comment thread src/cli/rustup_mode.rs Outdated
Comment thread src/cli/ci/base.env Outdated
@weihanglo

weihanglo commented Aug 25, 2026

Copy link
Copy Markdown
Member

FWIW, I created this thread for t-cargo to take a look, in case others have some ideas/concerns for the cargo part.

#t-cargo > `rustup ci` environment variables

Co-authored-by: r7kamura <r7kamura@gmail.com>
@rami3l
rami3l force-pushed the x/rustup-ci-subcmd branch from 5917940 to 2a3e6b2 Compare August 26, 2026 08:48
@rustbot

rustbot commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rami3l
rami3l marked this pull request as draft August 26, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants