Skip to content

add smoketest for std::net::hostname#158480

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
RalfJung:hostname-test
Jun 27, 2026
Merged

add smoketest for std::net::hostname#158480
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
RalfJung:hostname-test

Conversation

@RalfJung

@RalfJung RalfJung commented Jun 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This function is currently not invoked by any test, which is why I didn't even realize that Miri does not support it.

Tracking issue: #135142

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 27, 2026
@rustbot

rustbot commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 13 candidates
  • Random selection from Darksonn, JohnTitor, Mark-Simulacrum, clarfonthey, jhpratt

@RalfJung

RalfJung commented Jun 27, 2026

Copy link
Copy Markdown
Member Author

r? @joboet

@rustbot

rustbot commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

joboet is currently at their maximum review capacity.
They may take a while to respond.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@joboet

joboet commented Jun 27, 2026

Copy link
Copy Markdown
Member

Oh yeah, true.
r=me with CI passing.

@RalfJung

RalfJung commented Jun 27, 2026

Copy link
Copy Markdown
Member Author

Eh, how can I tell tidy that this is okay?

tidy [pal (library)]: library/std/src/net/hostname.rs:29: platform-specific cfg: cfg!(windows)
tidy [pal (library)]: library/std/src/net/hostname.rs:29: platform-specific cfg: cfg!(unix)
tidy [pal (library)]: FAIL

@rustbot rustbot added A-tidy Area: The tidy tool T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 27, 2026
@RalfJung

RalfJung commented Jun 27, 2026

Copy link
Copy Markdown
Member Author

I moved the test to library/std/src/net/test.rs and excluded test files from that tidy check. Is that okay? Not sure whom to ping for tidy things.

@joboet

joboet commented Jun 27, 2026

Copy link
Copy Markdown
Member

That seems fine, although I think renaming that file to tests.rs so it falls under the existing exception would be even better.

@RalfJung

RalfJung commented Jun 27, 2026

Copy link
Copy Markdown
Member Author

Ah right that seems like the usual convention... there are only a few exceptions

$ find library -name test.rs
library/stdarch/crates/core_arch/src/x86/test.rs
library/stdarch/crates/core_arch/src/test.rs
library/std/src/net/test.rs

@joboet

joboet commented Jun 27, 2026

Copy link
Copy Markdown
Member

@bors r+

@rust-bors

rust-bors Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

📌 Commit cf443cb has been approved by joboet

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2026
@joboet joboet removed T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-tidy Area: The tidy tool labels Jun 27, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 27, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Jun 27, 2026
@bors
Auto merge of #158487 - JonathanBrouwer:rollup-ln8LEcs, r=JonathanBro…
217fdd1 
…uwer

Rollup of 13 pull requests

Successful merges:

 - #157871 ([rustdoc] Update `doc_cfg` hide/show syntax)
 - #158234 (Cross-referencing tuple_trait tracking issue, source and the Unstable Book)
 - #158480 (add smoketest for std::net::hostname)
 - #157625 (Use infer tys for synthetic params when lowering const paths point to fns)
 - #158290 (add crashtests [1/N])
 - #158306 (tests: modify s390x vector test to be robust to instruction scheduling)
 - #158313 (Move `check_target_feature` into the attribute parser)
 - #158431 (More lint cleanups)
 - #158452 (Add missing links in integer docs)
 - #158467 (Add proc macro for unused assignments and corresponding test)
 - #158472 (Add regression test for unexpected pointer dereference issue)
 - #158475 (Fix doc comment on get_debug_as_hex.)
 - #158476 (Fix doc comment on FormattingOptions::new().)
rust-bors Bot pushed a commit that referenced this pull request Jun 27, 2026
@bors
Auto merge of #158487 - JonathanBrouwer:rollup-ln8LEcs, r=JonathanBro…
3522c34 
…uwer

Rollup of 13 pull requests

Successful merges:

 - #157871 ([rustdoc] Update `doc_cfg` hide/show syntax)
 - #158234 (Cross-referencing tuple_trait tracking issue, source and the Unstable Book)
 - #158480 (add smoketest for std::net::hostname)
 - #157625 (Use infer tys for synthetic params when lowering const paths point to fns)
 - #158290 (add crashtests [1/N])
 - #158306 (tests: modify s390x vector test to be robust to instruction scheduling)
 - #158313 (Move `check_target_feature` into the attribute parser)
 - #158431 (More lint cleanups)
 - #158452 (Add missing links in integer docs)
 - #158467 (Add proc macro for unused assignments and corresponding test)
 - #158472 (Add regression test for unexpected pointer dereference issue)
 - #158475 (Fix doc comment on get_debug_as_hex.)
 - #158476 (Fix doc comment on FormattingOptions::new().)
rust-bors Bot pushed a commit that referenced this pull request Jun 27, 2026
@bors
Auto merge of #158487 - JonathanBrouwer:rollup-ln8LEcs, r=JonathanBro…
18a5aaf 
…uwer

Rollup of 13 pull requests

Successful merges:

 - #157871 ([rustdoc] Update `doc_cfg` hide/show syntax)
 - #158234 (Cross-referencing tuple_trait tracking issue, source and the Unstable Book)
 - #158480 (add smoketest for std::net::hostname)
 - #157625 (Use infer tys for synthetic params when lowering const paths point to fns)
 - #158290 (add crashtests [1/N])
 - #158306 (tests: modify s390x vector test to be robust to instruction scheduling)
 - #158313 (Move `check_target_feature` into the attribute parser)
 - #158431 (More lint cleanups)
 - #158452 (Add missing links in integer docs)
 - #158467 (Add proc macro for unused assignments and corresponding test)
 - #158472 (Add regression test for unexpected pointer dereference issue)
 - #158475 (Fix doc comment on get_debug_as_hex.)
 - #158476 (Fix doc comment on FormattingOptions::new().)
rust-bors Bot pushed a commit that referenced this pull request Jun 27, 2026
@bors
Auto merge of #158487 - JonathanBrouwer:rollup-ln8LEcs, r=JonathanBro…
13f1859 
…uwer

Rollup of 13 pull requests

Successful merges:

 - #157871 ([rustdoc] Update `doc_cfg` hide/show syntax)
 - #158234 (Cross-referencing tuple_trait tracking issue, source and the Unstable Book)
 - #158480 (add smoketest for std::net::hostname)
 - #157625 (Use infer tys for synthetic params when lowering const paths point to fns)
 - #158290 (add crashtests [1/N])
 - #158306 (tests: modify s390x vector test to be robust to instruction scheduling)
 - #158313 (Move `check_target_feature` into the attribute parser)
 - #158431 (More lint cleanups)
 - #158452 (Add missing links in integer docs)
 - #158467 (Add proc macro for unused assignments and corresponding test)
 - #158472 (Add regression test for unexpected pointer dereference issue)
 - #158475 (Fix doc comment on get_debug_as_hex.)
 - #158476 (Fix doc comment on FormattingOptions::new().)
@rust-bors rust-bors Bot merged commit 6208d47 into rust-lang:main Jun 27, 2026
13 checks passed
@rustbot rustbot added this to the 1.98.0 milestone Jun 27, 2026
rust-timer added a commit that referenced this pull request Jun 27, 2026
@rust-timer
Unrolled build for #158480
611ed74 
Rollup merge of #158480 - RalfJung:hostname-test, r=joboet

add smoketest for std::net::hostname

This function is currently not invoked by any test, which is why I didn't even realize that Miri does not support it.

Tracking issue: #135142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joboet joboet

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

5 participants

@RalfJung @rustbot @rust-log-analyzer @joboet @jhpratt