Rollup of 5 pull requests#158471
Closed
jhpratt wants to merge 14 commits into
Closed
Conversation
A recent LLVM change causes some changes here, if I'm understanding correctly it allows some better latency reduction. From what I can tell, this test doesn't care that only a single register is used, so we use -DAG instead of -NEXT to allow some instruction reordering. By happy coincidence, the z10 and z13 code matches now, which collapsed some of the test lines. I'm happy to split them back out if that's bad for some reason though!
To explain some non-obvious things that took me some time to work out.
`EarlyLintPassObjects` is an old name.
As `*CombinedLateLintModPass`, because that matches things like `late_lint_mod`.
We generally write `lint_pass`/`LintPass`. This commit renames some things that only use `pass`/`Pass`. And also some `s/module/mod` changes, too.
There are `register_*_lint_pass` methods, might as well go through them.
…le_trait, r=chenyukang Cross-referencing tuple_trait tracking issue, source and the Unstable Book
Use infer tys for synthetic params when lowering const paths point to fns
```rust
#![feature(min_generic_const_args)]
trait Trait {}
impl<'t> Trait for [(); N] {}
fn N(arg: impl Trait) {}
```
1. `arg: impl Trait` implies a synthetic param `<impl Trait>` and the obligation `_: Trait`;
2. when matching `impl Trait for [(); N]`, lowering const arg `N` fills in that synthetic param, so the impl header contains `<[(); N::<impl Trait>] as Trait>`;
3. then instantiating this header with the impl's args causing a param/arg mismatch and ICE.
This PR uses infer tys for synthetic params. Although this will emit the error in `ItemCtxt` because infer tys are not allowed here. I think that is reasonable, because `N` omits the synthetic parameter, though we cannot write the ty explicitly anywhere.
Fixes rust-lang#155834
…itor tests: modify s390x vector test to be robust to instruction scheduling A recent LLVM change causes some changes here, if I'm understanding correctly it allows some better latency reduction. From what I can tell, this test doesn't care that only a single register is used, so we use -DAG instead of -NEXT to allow some instruction reordering. By happy coincidence, the z10 and z13 code matches now, which collapsed some of the test lines. I'm happy to split them back out if that's bad for some reason though!
…Urgau More lint cleanups Details in individual commits. r? Urgau
…hnTitor Add missing links in integer docs Saw some missing links while browsing the docs so fixed that.
rustbot
added
A-rustc-dev-guide
Member
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 27, 2026
Rollup of 5 pull requests Successful merges: - #158234 (Cross-referencing tuple_trait tracking issue, source and the Unstable Book) - #157625 (Use infer tys for synthetic params when lowering const paths point to fns) - #158306 (tests: modify s390x vector test to be robust to instruction scheduling) - #158431 (More lint cleanups) - #158452 (Add missing links in integer docs)
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for 9b14850 failed: CI. Failed job:
|
rust-bors
Bot
added
the
S-waiting-on-author
rustbot
removed
the
S-waiting-on-review
Contributor
|
This pull request was unapproved due to being closed. |
Collaborator
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
r? @ghost
Create a similar rollup