Move attribute and keyword docs from `std` to `core` by jschillem · Pull Request #158327 · rust-lang/rust

jschillem · 2026-06-23T19:54:24Z

Move the documentation for attributes and keywords into the core crate. Apart from strictly moving the module, I had to make a few small changes to certain docs to avoid using std types when possible, as well as fixing a few suggestions related to linking to primitives.

Pre-requisite for work on #157604.

r? @GuillaumeGomez

Verified documentation using:
./x doc library/core and ./x doc library/std, as well as running doc-tests for both crates.

rustbot · 2026-06-23T19:54:29Z

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

GuillaumeGomez · 2026-06-24T10:14:49Z

Thanks!

@bors r+ rollup

rust-bors · 2026-06-24T10:14:52Z

📌 Commit e5d79ed has been approved by GuillaumeGomez

It is now in the queue for this repository.

@GuillaumeGomez

…-keywords-to-core, r=GuillaumeGomez Move attribute and keyword docs from `std` to `core` Move the documentation for attributes and keywords into the `core` crate. Apart from strictly moving the module, I had to make a few small changes to certain docs to avoid using `std` types when possible, as well as fixing a few suggestions related to linking to primitives. Pre-requisite for work on rust-lang#157604. r? @GuillaumeGomez Verified documentation using: `./x doc library/core` and `./x doc library/std`, as well as running doc-tests for both crates.

@GuillaumeGomez

…-keywords-to-core, r=GuillaumeGomez Move attribute and keyword docs from `std` to `core` Move the documentation for attributes and keywords into the `core` crate. Apart from strictly moving the module, I had to make a few small changes to certain docs to avoid using `std` types when possible, as well as fixing a few suggestions related to linking to primitives. Pre-requisite for work on rust-lang#157604. r? @GuillaumeGomez Verified documentation using: `./x doc library/core` and `./x doc library/std`, as well as running doc-tests for both crates.

JonathanBrouwer · 2026-06-25T07:55:08Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #158389 (comment)

rust-bors · 2026-06-25T07:55:17Z

This pull request was unapproved.

This PR was contained in a rollup (#158389), which was unapproved.

View changes since this unapproval

GuillaumeGomez · 2026-06-25T14:14:46Z

@bors try job=test-various

…o-core, r=<try> Move attribute and keyword docs from `std` to `core` try-job: test-various

rust-bors · 2026-06-25T15:02:09Z

💔 Test for 6850d53 failed: CI. Failed job:

try - test-various (web logs, enhanced plaintext logs)

rust-bors · 2026-06-25T16:37:09Z

@jschillem: 🔑 Insufficient privileges: not in try users

rustbot · 2026-06-26T03:43:34Z

Error: Label Ameta can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

jschillem · 2026-06-26T03:45:54Z

Sorry about all the extra labels being added and comments! Borked a rebase 😅

rustbot · 2026-06-27T16:43:32Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

… tests

jschillem · 2026-06-27T19:46:20Z

@GuillaumeGomez could you run a test-various try job to test if the ignore fixes the CI fail case?

rustbot assigned GuillaumeGomez Jun 23, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 23, 2026

GuillaumeGomez approved these changes Jun 24, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2026

JonathanBrouwer mentioned this pull request Jun 25, 2026

Rollup of 18 pull requests #158386

Closed

JonathanBrouwer mentioned this pull request Jun 25, 2026

Rollup of 17 pull requests #158389

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 25, 2026

This comment has been minimized.

Sign in to view

rustbot added the has-merge-commits PR has merge commits, merge with caution. label Jun 25, 2026

jschillem force-pushed the docs-move-attributes-and-keywords-to-core branch from 2ce02ed to 8230837 Compare June 25, 2026 13:16

rustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Jun 25, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jun 25, 2026

Auto merge of #158327 - jschillem:docs-move-attributes-and-keywords-t…

6850d53

…o-core, r=<try> Move attribute and keyword docs from `std` to `core` try-job: test-various

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 25, 2026

This comment has been minimized.

Sign in to view

jschillem force-pushed the docs-move-attributes-and-keywords-to-core branch 2 times, most recently from 5ebd7f2 to 471fbdf Compare June 26, 2026 03:35

This comment has been minimized.

Sign in to view

RalfJung reviewed Jun 26, 2026

View reviewed changes

Comment thread library/core/src/keyword_docs.rs Outdated

RalfJung reviewed Jun 26, 2026

View reviewed changes

Comment thread library/core/src/keyword_docs.rs Outdated

RalfJung reviewed Jun 26, 2026

View reviewed changes

Comment thread library/std/src/lib.rs

This comment has been minimized.

Sign in to view

jschillem added 4 commits June 27, 2026 12:42

refactor: move attribute and keywords docs files to core

ad0ec74

fix references to std

f8abac3

tidy fixes

05922ef

ignore doc tests w/ explicit_tail_calls

a40f3d5

jschillem force-pushed the docs-move-attributes-and-keywords-to-core branch from 8e77041 to a40f3d5 Compare June 27, 2026 16:43

RalfJung reviewed Jun 27, 2026

View reviewed changes

Comment thread library/std/src/lib.rs Outdated

jschillem added 3 commits June 27, 2026 13:09

revert unsafe example and ignore specifically WASM for become doc…

5b094ee

… tests

add explicit note about doube including the docs in core and std

9eb0ce4

missed refactoring of doc test ignore

b050ccf

Uh oh!

Uh oh!

Conversation

jschillem commented Jun 23, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 23, 2026

Uh oh!

GuillaumeGomez commented Jun 24, 2026

Uh oh!

rust-bors Bot commented Jun 24, 2026

Uh oh!

JonathanBrouwer commented Jun 25, 2026

Uh oh!

rust-bors Bot commented Jun 25, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

GuillaumeGomez commented Jun 25, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 25, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 25, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Jun 26, 2026

Uh oh!

jschillem commented Jun 26, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

rustbot commented Jun 27, 2026

Uh oh!

Uh oh!

jschillem commented Jun 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jschillem commented Jun 23, 2026 •

edited by rustbot

Loading

jschillem commented Jun 27, 2026 •

edited

Loading