Skip to content

Revert "Add expansion info to implied bounds"#158122

Open
JonathanBrouwer wants to merge 2 commits into
rust-lang:mainfrom
JonathanBrouwer:revert-expansion-info
Open

Revert "Add expansion info to implied bounds"#158122
JonathanBrouwer wants to merge 2 commits into
rust-lang:mainfrom
JonathanBrouwer:revert-expansion-info

Conversation

@JonathanBrouwer

@JonathanBrouwer JonathanBrouwer commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

This reverts PR #157702 because it causes an ICE and a significant perf regression. This PR also adds a regression test for the ICE.

r? ghost
cc @oli-obk @estebank @davidtwco

Fixes #158093

…pansion-info, r=davidtwco,estebank"

This reverts commit 18509d2, reversing
changes made to bf0dfb6.
@rustbot

rustbot commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

HIR ty lowering was modified

cc @fmease

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 19, 2026
@rustbot

rustbot commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@JonathanBrouwer

Copy link
Copy Markdown
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 19, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
Revert "Add expansion info to implied bounds"
@rust-bors

rust-bors Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 7e32970 (7e3297093340be87843a6cfe127723386872d136)
Base parent: 8e15021 (8e150217bafcaaaa0c45bf685c55fd56cec48598)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (7e32970): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.1% [0.8%, 1.4%] 2
Improvements ✅
(primary)
-0.6% [-2.8%, -0.1%] 76
Improvements ✅
(secondary)
-0.6% [-1.8%, -0.2%] 56
All ❌✅ (primary) -0.6% [-2.8%, -0.1%] 76

Max RSS (memory usage)

Results (primary -1.9%, secondary -2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.0% [1.0%, 1.0%] 1
Regressions ❌
(secondary)
5.0% [2.5%, 6.1%] 4
Improvements ✅
(primary)
-2.1% [-4.2%, -0.6%] 24
Improvements ✅
(secondary)
-5.2% [-12.7%, -0.9%] 10
All ❌✅ (primary) -1.9% [-4.2%, 1.0%] 25

Cycles

Results (primary -3.0%, secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.5% [2.2%, 2.7%] 3
Improvements ✅
(primary)
-3.0% [-4.4%, -2.0%] 16
Improvements ✅
(secondary)
-3.3% [-5.1%, -2.3%] 17
All ❌✅ (primary) -3.0% [-4.4%, -2.0%] 16

Binary size

Results (primary -1.7%, secondary -1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.7% [-11.0%, -0.0%] 110
Improvements ✅
(secondary)
-1.7% [-10.7%, -0.0%] 66
All ❌✅ (primary) -1.7% [-11.0%, -0.0%] 110

Bootstrap: 481.812s -> 480.604s (-0.25%)
Artifact size: 390.71 MiB -> 391.19 MiB (0.12%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 19, 2026
@JonathanBrouwer

JonathanBrouwer commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

r? compiler

@JonathanBrouwer

Copy link
Copy Markdown
Contributor Author

If you have r+ privileges, you can self-approve a revert if the revert is clean and is unlikely to cause new regressions on its own

The revert was clean and I think unlikely to cause regressions
@bors r+ rollup=never

@rust-bors

rust-bors Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 1e5f587 has been approved by JonathanBrouwer

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Contributor Author

@bors p=5
Scheduling this to run after the rollup

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
…thanBrouwer

Revert "Add expansion info to implied bounds"

This reverts PR #157702 because it causes an ICE and a significant perf regression. This PR also adds a regression test for the ICE.

r? ghost
cc @oli-obk @estebank @davidtwco 

Fixes #158093
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
...............................F.................. (50/144)
.................................................. (100/144)
............................................       (144/144)

======== tests/rustdoc-gui/go-to-collapsed-elem.goml ========

[ERROR] line 40
    at `tests/rustdoc-gui/go-to-collapsed-elem.goml` line 21: Error: Node is detached from document: for command `click: "//*[@id='search']//a[@href='../test_docs/struct.Foo.html#method.must_use']"`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.Foo.html?search=t_use>


<= doc-ui tests done: 143 succeeded, 1 failed, 0 filtered out

Error: ()

@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 19, 2026
@rust-bors

rust-bors Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 272d4be failed: CI. Failed job:

@JonathanBrouwer

Copy link
Copy Markdown
Contributor Author

@bors retry

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2026
@rust-bors

rust-bors Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

⌛ Testing commit 1e5f587 with merge d806608...

Workflow: https://github.com/rust-lang/rust/actions/runs/27833559400

rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
…thanBrouwer

Revert "Add expansion info to implied bounds"

This reverts PR #157702 because it causes an ICE and a significant perf regression. This PR also adds a regression test for the ICE.

r? ghost
cc @oli-obk @estebank @davidtwco 

Fixes #158093
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: Found unstable fingerprints for explicit_supertraits_containing_assoc_item

5 participants