Revert "Add expansion info to implied bounds"#158122
Conversation
|
HIR ty lowering was modified cc @fmease |
|
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Revert "Add expansion info to implied bounds"
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (7e32970): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -1.9%, secondary -2.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -3.0%, secondary -2.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -1.7%, secondary -1.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 481.812s -> 480.604s (-0.25%) |
|
r? compiler |
The revert was clean and I think unlikely to cause regressions |
|
@bors p=5 |
This comment has been minimized.
This comment has been minimized.
…thanBrouwer Revert "Add expansion info to implied bounds" This reverts PR #157702 because it causes an ICE and a significant perf regression. This PR also adds a regression test for the ICE. r? ghost cc @oli-obk @estebank @davidtwco Fixes #158093
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test for 272d4be failed: CI. Failed job:
|
|
@bors retry |
|
⌛ Testing commit 1e5f587 with merge d806608... Workflow: https://github.com/rust-lang/rust/actions/runs/27833559400 |
…thanBrouwer Revert "Add expansion info to implied bounds" This reverts PR #157702 because it causes an ICE and a significant perf regression. This PR also adds a regression test for the ICE. r? ghost cc @oli-obk @estebank @davidtwco Fixes #158093
This reverts PR #157702 because it causes an ICE and a significant perf regression. This PR also adds a regression test for the ICE.
r? ghost
cc @oli-obk @estebank @davidtwco
Fixes #158093