Stabilize strip_circumfix#158012
Conversation
|
r? @joboet rustbot has assigned @joboet. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
r? libs-api |
|
@joboet It already had an FCP in #147946 (comment). |
|
@joboet the tracking issue already went through an FCP. Isn't that enough? (Sorry if I'm being ignorant, first time going through the stabilization process) |
This comment has been minimized.
This comment has been minimized.
a130f53 to
fd30268
Compare
|
Oh, whoops, I didn't check... In that case, r=me with CI passing. |
|
Thanks! |
|
Note that you need to keep around the feature gates, but only in the bootstrap compiler (since the feature is still unstable in the beta- |
fd30268 to
439746b
Compare
|
Got it, thanks! |
|
@bors r=joboet |
|
📋 This PR cannot be approved because it currently has the following label: |
|
@rustbot label -needs-fcp |
|
@bors r=joboet |
…mfix, r=joboet Stabilize `strip_circumfix` Tracking issue: rust-lang#147946
…uwer Rollup of 8 pull requests Successful merges: - #157788 (Accumulate multiple -Zsanitizer target modifiers) - #158012 (Stabilize `strip_circumfix`) - #157810 (Query the trait solver in slow path for `missing_debug_implementations`) - #157829 (tests: adapt two tests for LLVM 23 changes) - #157917 (Don't suggest adding `in` to a `for` loop that already has one) - #157967 (Preserve track_caller for by-value dyn vtable shims) - #158019 (delegation: add simple test for incremental compilation) - #158023 (Move `UnusedDuplicate` diag struct to `rustc_attr_parsing`)
…uwer Rollup of 12 pull requests Successful merges: - #157788 (Accumulate multiple -Zsanitizer target modifiers) - #158012 (Stabilize `strip_circumfix`) - #157810 (Query the trait solver in slow path for `missing_debug_implementations`) - #157829 (tests: adapt two tests for LLVM 23 changes) - #157873 (mips: set llvm_args -mno-check-zero-division for all mips targets) - #157886 (Reject extra fields in MGCA struct const arguments) - #157917 (Don't suggest adding `in` to a `for` loop that already has one) - #157967 (Preserve track_caller for by-value dyn vtable shims) - #158019 (delegation: add simple test for incremental compilation) - #158023 (Move `UnusedDuplicate` diag struct to `rustc_attr_parsing`) - #158029 (Rename `project-stable-mir` to `project-rustc-public`) - #158044 (Add more tests for parallel frontend issues)
…uwer Rollup of 12 pull requests Successful merges: - rust-lang/rust#157788 (Accumulate multiple -Zsanitizer target modifiers) - rust-lang/rust#158012 (Stabilize `strip_circumfix`) - rust-lang/rust#157810 (Query the trait solver in slow path for `missing_debug_implementations`) - rust-lang/rust#157829 (tests: adapt two tests for LLVM 23 changes) - rust-lang/rust#157873 (mips: set llvm_args -mno-check-zero-division for all mips targets) - rust-lang/rust#157886 (Reject extra fields in MGCA struct const arguments) - rust-lang/rust#157917 (Don't suggest adding `in` to a `for` loop that already has one) - rust-lang/rust#157967 (Preserve track_caller for by-value dyn vtable shims) - rust-lang/rust#158019 (delegation: add simple test for incremental compilation) - rust-lang/rust#158023 (Move `UnusedDuplicate` diag struct to `rustc_attr_parsing`) - rust-lang/rust#158029 (Rename `project-stable-mir` to `project-rustc-public`) - rust-lang/rust#158044 (Add more tests for parallel frontend issues)
Tracking issue: #147946