Add tree top method to Syntax node - #22668
Merged
ChayimFriedman2 merged 2 commits intoJun 30, 2026
Merged
Conversation
rustbot
added
the
S-waiting-on-review
Contributor
|
I actually prefer this to be a method in rowan (on both |
Contributor
|
Ah and you need to base this on the 0.15 version series, 0.16 has some changes that break us. |
Member
Author
|
PR on rowan with version bump: rust-analyzer/rowan#213 |
Member
Author
|
I will update this PR, once we publish v0.15.19 |
bit-aloo
force-pushed
the
2026-06-30-add-tree-top-method
branch
from
June 30, 2026 09:21
19f3036 to
eb0a1d9
Compare
bit-aloo
force-pushed
the
2026-06-30-add-tree-top-method
branch
from
June 30, 2026 09:28
eb0a1d9 to
489a0ea
Compare
ChayimFriedman2
approved these changes
Jun 30, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tree top method to syntax node, to fetch the root, instead of letting the user do that everytime.