Skip to content

hurd: make ifaddrs.ifa_ifu an union - #5744

Open
pinotree wants to merge 1 commit into
rust-lang:mainfrom
pinotree:hurd-ifaddrs.ifa_ifu
Open

pinotree wants to merge 1 commit into
rust-lang:mainfrom
pinotree:hurd-ifaddrs.ifa_ifu

Conversation

@pinotree

Copy link
Copy Markdown
Contributor

Mimic commit cbb9b0b in the Hurd implementation, as the definition by GNU libc is the same as on Linux:
https://sourceware.org/git/?p=glibc.git;a=blob;f=inet/ifaddrs.h;h=1893b2f36f761f172b5f34642b5348d61b862d72;hb=HEAD

@pinotree

Copy link
Copy Markdown
Contributor Author

@sthibaul PTAL :)

This is to not be backported to stable, as the Linux implementation does not use this approach in stable either.

@sthibaul

Copy link
Copy Markdown
Contributor

LGTM, thanks!

Comment thread src/unix/hurd/mod.rs
Comment on lines +1164 to +1165
ifu_broadaddr: *mut sockaddr,
ifu_dstaddr: *mut sockaddr,

@JohnTitor JohnTitor Nov 17, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it'd be useful to make them public, wouldn't it?

View changes since the review

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as the linux version?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point; let me fix first the existing implementations, so this can be done "properly" from the beginning: #5745

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I wasn't aware of that, thank you for the follow-up!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants