Repository navigation
Conversation
Mimic commit cbb9b0b in the Hurd implementation, as the definition by GNU libc is the same as on Linux: https://sourceware.org/git/?p=glibc.git;a=blob;f=inet/ifaddrs.h;h=1893b2f36f761f172b5f34642b5348d61b862d72;hb=HEAD
Contributor
Author
|
@sthibaul PTAL :) This is to not be backported to stable, as the Linux implementation does not use this approach in stable either. |
Contributor
|
LGTM, thanks! |
JohnTitor
reviewed
Nov 17, 2026
Comment on lines
+1164
to
+1165
| ifu_broadaddr: *mut sockaddr, | ||
| ifu_dstaddr: *mut sockaddr, |
Member
There was a problem hiding this comment.
Maybe it'd be useful to make them public, wouldn't it?
Contributor
There was a problem hiding this comment.
This is the same as the linux version?
Contributor
Author
There was a problem hiding this comment.
Good point; let me fix first the existing implementations, so this can be done "properly" from the beginning: #5745
Member
There was a problem hiding this comment.
Oh, I wasn't aware of that, thank you for the follow-up!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mimic commit cbb9b0b in the Hurd implementation, as the definition by GNU libc is the same as on Linux:
https://sourceware.org/git/?p=glibc.git;a=blob;f=inet/ifaddrs.h;h=1893b2f36f761f172b5f34642b5348d61b862d72;hb=HEAD