FreeBSD: Add SOL_LOCAL#5185
Conversation
|
Please add links to the relevant headers in the PR description when adding/changing API (the PR template asks for this). But this seems fine to me, cc @asomers for FreeBSD |
|
You can edit the description and add that all, including the header links :) |
|
| SOCK_NONBLOCK | ||
| SOCK_RAW | ||
| SOCK_RDM | ||
| SOL_LOCAL |
There was a problem hiding this comment.
Does this line really belong here?
There was a problem hiding this comment.
No, it doesn't. I have moved the SOL_LOCAL definition out of the shared freebsdlike module into freebsd/mod.rs, and removed it from dragonfly.txt.
There was a problem hiding this comment.
Content LGTM but this needs a squash, and the commit messages need to be updated to reflect that this is now FreeBSD-only.
The PR template says:
All API changes must have permalinks to headers.
This is so reviewers don't need to hunt for the sources to verify against. I have updated your PR description here, but please make sure to follow what the template asks for in the future.
|
Reminder, once the PR becomes ready for a review, use |
Add SOL_LOCAL constant (value 0) to FreeBSD to match Apple/macOS targets and allow setting local socket options.
mansiverma897993
force-pushed
the
feat/add-sol-local-freebsd
branch
from
425611e to
321e24b
Compare
|
@rustbot ready |
|
@rustbot ready |
|
@tgross35 now check everything is correct or need do it again ? |
tgross35
changed the title
tgross35
added
the
stable-nominated
4 participants
Add SOL_LOCAL constant (value 0) to FreeBSD-like targets (FreeBSD and DragonFlyBSD) to match Apple/macOS targets and allow setting local socket options. Also added it to semver test files.
Source: https://cgit.freebsd.org/src/tree/sys/sys/un.h?id=fa515f60fce0edd09d0b1078852ec06b1cd0a74c#n62
Closes: #5168