l4re: change bit widths of file offset types#5173
Open
dybucc wants to merge 1 commit into
Open
Conversation
rustbot
added
S-waiting-on-review
stable-nominated
dybucc
force-pushed
the
l4re-file-offsets
branch
from
a64dd66 to
66c2f42
Compare
dybucc
changed the title
dybucc
force-pushed
the
l4re-file-offsets
branch
from
66c2f42 to
244c00b
Compare
This comment has been minimized.
This comment has been minimized.
dybucc
changed the title
dybucc
force-pushed
the
l4re-file-offsets
branch
from
244c00b to
f0bf0bf
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
dybucc
force-pushed
the
l4re-file-offsets
branch
from
f0bf0bf to
caac209
Compare
This patch makes a few changes to the file offset types and routines that are made available under the `unix/linux_like/l4re` module. The current upstream definitions under x86_64 and AArch64 are unconditionally 64-bit. Then there's the fact there's only one target officially supported by rustc under L4Re, and that's x86_64.
dybucc
force-pushed
the
l4re-file-offsets
branch
from
caac209 to
e16db76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR deprecates a number of symbols from the
unix/linux_like/l4remodule. This has also come with further deprecations and modifications in other top-level modules.At present, the definitions in upstream l4re-core are always 64-bit wide for the 64-bit targets we seem to support in this module. Though rustc only has support for x86_64 under this target OS.
Sources
Sources on the uClibc changes are documented in #5165. A regex search of the affected symbols on l4re-core's
libcdirectory reveals no modifications in their patches would necessitate changes in this patch.Checklist
libc-test/semverhave been updated*LASTor*MAXare included (see #3131)cd libc-test && cargo test --target mytarget); especially relevant for platforms that may not be checked in CI@rustbot label +stable-nominated