build queue: refactor & cache priority-finding for new releases#3378
Open
syphar wants to merge 1 commit into
Open
build queue: refactor & cache priority-finding for new releases#3378syphar wants to merge 1 commit into
syphar wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
S-waiting-on-review
syphar
force-pushed
the
cached-priorities
branch
3 times, most recently
from
f519c43 to
54fbb41
Compare
syphar
changed the title
syphar
force-pushed
the
cached-priorities
branch
from
15607ca to
96f788a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prep-work for the SQS ingestion from crates.io.
previously we had a point where we could call
deprioritize_workspaces( = once a minute, after we handled the events from onegit fetch).With SQS / events we don't have that any more, or it would be after every single event we receive.
I'll use this as a change to unify unify the "find prio" logic in one struct, and cache the necessary data.
we still need a call (
refresh_default_priorities) every now and then, which would for example update priorities of already queued releases, if the underlying data changes (patterns, workspace sizes, ...), but that's more optional.While I was on it, I also added a builder to the
FakeGithubStatsstruct and improved some code quality in tests