Skip to content

feat: add rp endpoint command group - #640

Open
KAJdev wants to merge 14 commits into
zeke/con-1119-rp-podfrom
zeke/con-1153-rp-endpoint
Open

KAJdev wants to merge 14 commits into
zeke/con-1119-rp-podfrom
zeke/con-1153-rp-endpoint

Conversation

@KAJdev

@KAJdev KAJdev commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Adds serverless configuration, worker visibility, and job execution on top of #639. Shared resolution, rendering, and logging keep resource commands consistent. Queue jobs use the SDK data plane; load-balancer requests target the endpoint HTTP URL.

@KAJdev
KAJdev changed the base branch from zeke/con-1118-rp-catalog to zeke/con-1119-rp-pod October 20, 2026 00:56
@KAJdev
KAJdev added this pull request to stack #642 October 20, 2026 00:56
@KAJdev
KAJdev requested a review from deanq October 20, 2026 01:11
@deanq
deanq requested a balanced review from Copilot October 20, 2026 05:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Streaming timeout handling, JSON output consistency, and preservation of omitted GPU exclusions need correction.

4 open issues
What changed in this PR

Adds rp endpoint commands for serverless management, building on the shared CLI utilities introduced for pod commands.

Changes:

  • Adds endpoint configuration, scaling, worker visibility, releases, and logs.
  • Supports queue jobs through the SDK and load-balancer HTTP requests.
  • Adds CLI tests for configuration, execution, and error handling.
File Description
tests/​test_cli/​test_endpoint_command.py Tests endpoint commands and validation.
runpod/​rp_cli/​main.py Registers the endpoint command group.
runpod/​rp_cli/​endpoint.py Implements endpoint management and execution commands.
runpod/​rp_cli/​endpoint_config.py Builds, validates, and patches endpoint configuration.

Review effort: Balanced

Comment thread runpod/rp_cli/endpoint.py Outdated
Comment thread runpod/rp_cli/endpoint.py Outdated
Comment thread runpod/rp_cli/endpoint.py Outdated
Comment thread runpod/rp_cli/endpoint_config.py Outdated
Comment thread runpod/rp_cli/endpoint.py Outdated
Comment thread runpod/rp_cli/endpoint.py Outdated
Comment thread runpod/rp_cli/endpoint_config.py Outdated
Comment thread runpod/rp_cli/endpoint.py Outdated
Comment thread runpod/rp_cli/endpoint_config.py Outdated
Comment thread runpod/rp_cli/endpoint.py
Comment thread runpod/rp_cli/endpoint.py
@KAJdev
KAJdev requested a review from deanq October 21, 2026 20:25
Comment thread runpod/rp_cli/endpoint.py
)
version = state.get("endpointVersion")
elapsed = time.monotonic() - started
waiting_for_release = (

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this fixes the lagging-release case. The flip side is a PATCH that never creates a release: with the 10s window gone, _follow_rollout now polls until --timeout (600s by default) and only then says "no new release observed". rp endpoint edit follows by default, so if any of the editable fields (scaling or idle timeout, for example) update the endpoint without bumping endpointVersion, a routine edit sits for 10 minutes. Does every PATCH create a release? If not, could _apply skip following when the patch only touches non-release fields, or could the PATCH response tell us whether a release is coming?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants