Skip to content

[RUN-4584] excludes commons-logging only added for test#44

Open
ronaveva wants to merge 2 commits into
mainfrom
RUN-4584
Open

[RUN-4584] excludes commons-logging only added for test#44
ronaveva wants to merge 2 commits into
mainfrom
RUN-4584

Conversation

@ronaveva

Copy link
Copy Markdown

Jira ticket: https://pagerduty.atlassian.net/browse/RUN-4584

commons-logging dependency is excluded to avoid conflict when running on rundeck
commons-logging added for test scope only

@ronaveva ronaveva added this to the 6.1.0 milestone Jul 13, 2026
@ronaveva ronaveva requested review from a team and Copilot July 13, 2026 20:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the plugin’s dependency packaging to avoid bundling commons-logging (which can conflict with Rundeck’s spring-jcl at runtime) while still making commons-logging available for tests.

Changes:

  • Moved the Apache HttpClient version into gradle.properties.
  • Excluded transitive commons-logging from the packaged httpclient dependency so it won’t be bundled into the plugin JAR.
  • Added commons-logging as a testRuntimeOnly dependency to support test execution.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
gradle.properties Introduces centralized version properties for HttpClient and commons-logging.
build.gradle Excludes transitive commons-logging from the packaged plugin libs and adds commons-logging for tests only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants