Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Owner
Author
|
Benchmark source, project settings, original result tables, and reproduction instructions: https://gist.github.com/runceel/0798793e06ba86c46bd347bfc1f0e202. This includes the substantial first-use compilation downside. A getter-only generic-reflection prototype measured fresh delegate use at 386 ± 90 ns / 392 B versus the compiled adapter at 142.7 ± 86.8 µs / 10,386 B in the same later ShortRun; its warm getter measured 3.43 ± 0.40 ns / 0 B. These are isolated microbenchmarks, not cold-process or application measurements. The prototype uses MakeGenericMethod; setter behavior, trimming and Native AOT have not been established. It is not in the PR and does not resolve its startup/compatibility trade-off. Keep this PR in draft. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up for #569 item 1: replace property-path DynamicInvoke with cached typed accessor adapters in Core and Legacy. Independent of #574; no R3 edits. Based on main including merged .NET 11 support (#573).
Draft: important unresolved trade-off
Warm calls improve, but compiling a fresh getter adapter significantly increases first-use cost and allocations. No application-level break-even has been established. Native AOT/trimming are unvalidated. This is a draft for evaluation, NOT a claim that all performance acceptance criteria are satisfied. #569 must remain open.
Reported measurements
Same-machine .NET 11 ARM64 Release BenchmarkDotNet in-process ShortRun, after dry run. Error is the 99.9% confidence-interval half-width; these microbenchmarks have wide uncertainty and do not predict whole-application speedups.
The last scenario includes candidate adapter compilation on every operation; it excludes full path creation and first-time property discovery, and is not a cold-process benchmark.
Verification reported by implementation session
See ADR 0009 for design and limitations. No packages published; no merge requested.