Skip to content

Remove retired UWP and Xamarin integrations - #572

Open
runceel wants to merge 5 commits into
mainfrom
runceel-uwp-and-xamarin-removal
Open

runceel wants to merge 5 commits into
mainfrom
runceel-uwp-and-xamarin-removal

Conversation

@runceel

@runceel runceel commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Summary

Closes #571.

  • Remove the retired UWP project and UWP-only branches; retain WPF implementations and existing public collection interfaces.
  • Remove UWP/Xamarin package recommendations, current English/Japanese tutorials (including the old UWP-based Uno tutorial), and their obsolete recordings/screenshots. Convert shared feature examples to WPF bindings, behaviors, and file picking.
  • Clean solution asset references and repository-specific guidance; record the decision in ADR 0008. Preserve generic MSTest/MTP skills, including their upstream UWP support information and limitations.
  • Preserve historical release notes/ADRs and previously published NuGet packages. No packages are removed or unlisted.
  • Add persistent tests extracting actual Markdown C#/XAML for all 28 localized WPF Pages. Make the filtering model's periodic subscription disposable so the example can be cleaned up.
  • Keep ordinary Run All completely noninteractive. Actual OS file-picker checks live in the existing ReactiveProperty.WPF.ManualTests app, not conditional/Inconclusive test cases. Remove the environment flag and native UIAutomation/PInvoke test helper.

Automatic runtime verification

The previous scratch-project check only proved compilation. The follow-up runs Pages and their documented ViewModels on a dedicated STA/WPF dispatcher, checking binding diagnostics and rendered state.

Examples (both languages) Automatic coverage
Collections (10 Pages) Start/clear, parent RemoveCommand in item templates, reset, filter membership and displayed item updates
Commanding (8 Pages) Displayed time, asynchronous command start/finish, disable/re-enable, shared CanExecute, validated input
ReactiveProperty (4 Pages) Validation messages and WPF error state, combined HasErrors checkbox
POCO synchronization (2 Pages) Both TextBoxes and the actual underlying model synchronize
Event transfer (4 Pages) Real Button Click events, deterministic EventArgs conversion, observable notifications, and displayed values. Clone the documented trigger actions with their XAML bindings and attach a test converter before subscribing; do not invoke the OS picker in automatic tests.
  • Ordinary dotnet test ReactiveProperty.slnx --no-restore -m:1 --verbosity minimal --logger trx: 678 passed, zero failed/skipped/Inconclusive, across .NET 10 and .NET 11. No environment opt-in. Confirmed all 678 actual TRX outcomes are Passed.
  • Ordinary VSTest adapter discovery exposes the new noninteractive event tests on both frameworks; no conditional native-dialog tests remain.
  • dotnet build ReactiveProperty.slnx -c Release --no-restore --verbosity quiet: succeeds, including the manual app and generated Page resources.
  • Earlier WPF sample Release build succeeds with zero warnings/errors; full sample-solution build and deleted-asset/link checks also passed. git diff --check is clean.

Manual file-picker verification

Run the existing ReactiveProperty.WPF.ManualTests startup project and choose Start test under Documentation event-transfer / file-picker test. Its four tabs load the actual English/Japanese command/property Pages and unmodified documented converters, using the same Markdown extractor as the automatic tests.

In each tab: select an existing .snippet file and check the full path; reopen and cancel without changing the displayed value; select another file and check the update. The new manual window was launched and these interactions checked for all four tabs; the app closes normally. These OS-dialog checks are separate from automated test coverage and are not run by CI. Detailed steps are in dev-docs/README.md.

Integration / remaining risk

#573 is merged into main and incorporated here. Shared-file conflicts retain all six active-package framework facts, .NET Framework 4.7.2-or-later wording, .NET 11/C#14 guidance, and ADR 0007 alongside this PR's retired-platform removals and ADR 0008. Framework/CI/package-version changes come from main, not this PR's diff. No stacking dependency.

Existing nullable/analyzer warnings and previously reported Blazor sample dependency advisories are outside this cleanup. This PR remains unmerged for human review.

Remove unsupported source and conditional branches, retire current platform tutorials and media, and preserve shared feature guidance as WPF examples. Keep published packages, historical records, and supported framework targets unchanged.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
kaota_microsoft and others added 4 commits November 17, 2026 16:06
Keep upstream MSTest support information and MTP limitations independent of ReactiveProperty's retired platform support.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Compile actual Markdown models and XAML, exercise real controls and native file dialogs, and dispose the filtering example timer.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep normal test discovery fully noninteractive, retaining real WPF event/converter notification assertions without Inconclusive results or environment flags. Reuse actual Markdown examples in the manual UI.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

現行コード・設定・ドキュメントからUWP/Xamarin対応を除去する

2 participants