Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
* Please see the [README](README.md#schema) for more documentation on the
YAML Schema.
* Prior to submitting a pull request, run the tests:

* Advisory filename and the root of the `url:` field must
be equal `(as of 5/10/2026).`
```
bundle install
bundle exec rspec
Expand Down
6 changes: 2 additions & 4 deletions gems/faraday/CVE-2026-33637.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
gem: faraday
cve: 2026-33637
ghsa: 5rv5-xj5j-3484
url: https://github.com/lostisland/faraday/security/advisories/GHSA-5rv5-xj5j-3484
url: https://nvd.nist.gov/vuln/detail/CVE-2026-33637
title: Faraday has a possible incomplete fix for GHSA-33mh-2634-fwr2 -
protocol-relative URI objects still bypass host scoping
date: 2026-05-18
Expand Down Expand Up @@ -31,7 +31,7 @@ description: |
that believe they are constrained to a fixed base URL. If the
connection carries default headers or query parameters, those
values are forwarded to the attacker-selected host.
cvss_v3: 0.0
cvss_v3: 6.5
unaffected_versions:
- "< 2.0.0"
patched_versions:
Expand All @@ -43,5 +43,3 @@ related:
- https://github.com/lostisland/faraday/security/advisories/GHSA-5rv5-xj5j-3484
- https://github.com/advisories/GHSA-33mh-2634-fwr2
- https://github.com/advisories/GHSA-5rv5-xj5j-3484
notes: |
- ZERO CVSS value in GHSA and NVD
1 change: 1 addition & 0 deletions gems/jwt/CVE-2026-45363.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ patched_versions:
- ">= 3.2.0"
related:
url:
- https://www.cve.org/CVERecord?id=CVE-2026-45363
- https://github.com/jwt/ruby-jwt/security/advisories/GHSA-c32j-vqhx-rx3x
- https://github.com/jwt/ruby-jwt/commit/db560b769a07bd9724e77ff505011ac01872106f
- https://github.com/jwt/ruby-jwt/releases/tag/v3.2.0
Expand Down
15 changes: 15 additions & 0 deletions spec/advisory_example.rb
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,21 @@
it { expect(subject).to be_kind_of(String) }
it { expect(subject).to_not match(%r{\Ahttp(s)?://osvdb\.org}) }
it { expect(subject).not_to be_empty }

it "has a filename that matches the root of the url field" do
url = advisory["url"]

# Extract filename without extension
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is probably not necessary, the code is pretty clear.

filename_root = File.basename(path, ".yml")

# 5/24/2026: May 9, 2026 is earliest start date with no failed checks.
start_date = Date.new(2026, 5, 9)
Comment thread
jasnow marked this conversation as resolved.
# Skip advisories older than start_date and old OSVDB advisories.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is also probably unnecessary, the code reads well.

if advisory["date"] >= start_date and !filename_root.start_with?("OSVDB")
expect(url).to include(filename_root),
"Expected base filename DOES NOT include URL"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Expected base filename ..." string doesn't do anything here, and should be dropped.

end
end
end

describe "title" do
Expand Down