Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@ Lint/DuplicateBranch:
Style/NegatedIf:
Enabled: false

# Disabling for now until it's clearer why we want this
Style/FrozenStringLiteralComment:
Enabled: false

# It's nice to be able to read the condition first before reading the code within the condition
Style/GuardClause:
Enabled: false
Expand Down
2 changes: 2 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

source 'https://rubygems.org'

# Specify your gem's dependencies in modularization_tools.gemspec
Expand Down
1 change: 1 addition & 0 deletions Rakefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# typed: ignore
# frozen_string_literal: true

require 'bundler/gem_tasks'
require 'rspec/core/rake_task'
Expand Down
1 change: 1 addition & 0 deletions lib/parse_packwerk.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# typed: strict
# frozen_string_literal: true

require 'sorbet-runtime'
require 'yaml'
Expand Down
1 change: 1 addition & 0 deletions lib/parse_packwerk/configuration.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# typed: strict
# frozen_string_literal: true

module ParsePackwerk
class Configuration < T::Struct
Expand Down
25 changes: 13 additions & 12 deletions lib/parse_packwerk/constants.rb
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
# typed: strict
# frozen_string_literal: true

module ParsePackwerk
ROOT_PACKAGE_NAME = T.let('.'.freeze, String)
PACKAGE_YML_NAME = T.let('package.yml'.freeze, String)
PACKWERK_YML_NAME = T.let('packwerk.yml'.freeze, String)
PACKAGE_TODO_YML_NAME = T.let('package_todo.yml'.freeze, String)
ENFORCE_DEPENDENCIES = T.let('enforce_dependencies'.freeze, String)
ENFORCE_PRIVACY = T.let('enforce_privacy'.freeze, String)
ENFORCE_LAYERS = T.let('enforce_layers'.freeze, String)
DEPENDENCY_VIOLATION_TYPE = T.let('dependency'.freeze, String)
PRIVACY_VIOLATION_TYPE = T.let('privacy'.freeze, String)
PUBLIC_PATH = T.let('public_path'.freeze, String)
METADATA = T.let('metadata'.freeze, String)
DEPENDENCIES = T.let('dependencies'.freeze, String)
ROOT_PACKAGE_NAME = T.let('.', String)
PACKAGE_YML_NAME = T.let('package.yml', String)
PACKWERK_YML_NAME = T.let('packwerk.yml', String)
PACKAGE_TODO_YML_NAME = T.let('package_todo.yml', String)
ENFORCE_DEPENDENCIES = T.let('enforce_dependencies', String)
ENFORCE_PRIVACY = T.let('enforce_privacy', String)
ENFORCE_LAYERS = T.let('enforce_layers', String)
DEPENDENCY_VIOLATION_TYPE = T.let('dependency', String)
PRIVACY_VIOLATION_TYPE = T.let('privacy', String)
PUBLIC_PATH = T.let('public_path', String)
METADATA = T.let('metadata', String)
DEPENDENCIES = T.let('dependencies', String)

# Since this metadata is unstructured YAML, it could be any type. We leave it to clients of `ParsePackwerk::Package`
# to add types based on their known usage of metadata.
Expand Down
1 change: 1 addition & 0 deletions lib/parse_packwerk/extensions.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# typed: strict
# frozen_string_literal: true

module ParsePackwerk
module Extensions
Expand Down
1 change: 1 addition & 0 deletions lib/parse_packwerk/package.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# typed: strict
# frozen_string_literal: true

module ParsePackwerk
class Package < T::Struct
Expand Down
1 change: 1 addition & 0 deletions lib/parse_packwerk/package_todo.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# typed: strict
# frozen_string_literal: true

module ParsePackwerk
class PackageTodo < T::Struct
Expand Down
1 change: 1 addition & 0 deletions lib/parse_packwerk/violation.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# typed: strict
# frozen_string_literal: true

module ParsePackwerk
class Violation < T::Struct
Expand Down
2 changes: 2 additions & 0 deletions parse_packwerk.gemspec
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

Gem::Specification.new do |spec|
spec.name = 'parse_packwerk'
spec.version = '0.27.0'
Expand Down
2 changes: 2 additions & 0 deletions spec/support/have_matching_package.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

RSpec::Matchers.define(:have_matching_package) do |expected_package, expected_package_todo|
match do |actual_packages|
@actual_packages = actual_packages
Expand Down
Loading