Removed singleton dependency#129
Open
hsbt wants to merge 1 commit into
Open
Conversation
I have a plan to extract singleton library as bundled gems at Ruby 3.5. We should rewrite singleton logic with simple ruby code.
jeremyevans
approved these changes
Jan 31, 2024
jeremyevans
left a comment
jeremyevans
left a comment
Collaborator
There was a problem hiding this comment.
I'm OK with this. I think it would be better to initialize the instance up front, and store it in a class instance variable. You could even make instance a singleton class attr_reader.
ioquatix
reviewed
Jan 31, 2024
| end | ||
|
|
||
| def self.instance | ||
| @instance ||= new |
Member
There was a problem hiding this comment.
Is this thread safe? (and/or is that a problem here?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a plan to extract singleton library as bundled gems at Ruby 3.5. We should rewrite singleton logic with simple ruby code.