Declare TypedData with RUBY_TYPED_THREAD_SAFE_FREE - #222
Merged
Conversation
Available on Ruby 4.1: [Feature #22067] Ref: https://bugs.ruby-lang.org/issues/22067 When available this flag superseed RUBY_TYPED_FREE_IMMEDIATELY and allow parallel sweeping of the type.
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jul 12, 2026
(ruby/stringio#222) Available on Ruby 4.1: [Feature #22067] Ref: https://bugs.ruby-lang.org/issues/22067 When available this flag superseed RUBY_TYPED_FREE_IMMEDIATELY and allow parallel sweeping of the type. ruby/stringio@8d27a7f4f1
jhawthorn
reviewed
Jul 29, 2026
| strio_free(void *p) | ||
| { | ||
| struct StringIO *ptr = p; | ||
| if (--ptr->count <= 0) { |
Member
There was a problem hiding this comment.
This is a thread unsafe pattern we need to look out for. If we free these in parallel (or concurrently with the mutator) we'll race on the count
Member
Author
There was a problem hiding this comment.
Oh good catch, sorry I overlooked that refcount :/
I suppose we could use anatomic, but might not be worth it.
kou
pushed a commit
that referenced
this pull request
Aug 1, 2026
Follow up to #222 This refcount previously wasn't thread safe (and shouldn't have been declared `RUBY_TYPED_THREAD_SAFE_FREE`), but it's easy enough to fix using ruby/atomic.h (Ruby 3.0+)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Available on Ruby 4.1: [Feature #22067]
Ref: https://bugs.ruby-lang.org/issues/22067
When available this flag superseed RUBY_TYPED_FREE_IMMEDIATELY and allow parallel sweeping of the type.