Give each DNS zone its own directory and add ruby-lang.org - #59
Merged
Conversation
A second Cloudflare zone is about to be added, and the two zones need separate credentials because the API tokens are zone scoped. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Exported with get-zones and confirmed to round-trip at 0 corrections. Unlike rubyci.org it is not applied from CI: the zone is shared with other maintainers, so push stays a deliberate manual step. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The ruby-lang.org token already carries its zone in the name, so the bare CLOUDFLARE_API_TOKEN was the odd one out and gave no hint about which of the two zone scoped tokens it held. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dns/directory held a single zone, so a second one had nowhere to put its credentials. Cloudflare API tokens are scoped to one zone each, which means every zone needs its owncreds.json, sodnsconfig.jsandcreds.jsonnow live underdns/<zone>/.ruby-lang.orgjoinsrubyci.orgunder DNSControl, exported withget-zonesand confirmed to round-trip. Storing it here was agreed with shugo. Unlikerubyci.orgit is not applied from CI. The zone is shared with other maintainers, sodnscontrol pushstays a deliberate manual step and no repository secret is added for it. Itscreds.jsonreadsCLOUDFLARE_API_TOKEN_RUBY_LANG_ORGrather than the namerubyci.orguses, so the wrong token cannot be picked up by accident.The workflow still applies
rubyci.orgalone, now fromdns/rubyci.org. Both zones preview at 0 corrections against the live zones.