ruby-rbs-sys: support wasm32-wasip1 - #3145
Open
pvcresin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
wasm32-wasip1build support forruby-rbs-sysandruby-rbs.Motivation
The vendored C parser needs to be compiled with the WASI SDK when the target is a WASI target.
In addition, bindgen output for wasm targets is sensitive to the libclang implementation. Depending on the environment, declarations may be dropped or forward-declared structs may be generated as opaque types.
For WASI builds, this change:
Native builds retain the existing behavior. No public Rust API is changed.
CI
Add a GitHub Actions job that builds both crates for
wasm32-wasip1.Testing
git diff --checkcargo fmt --all --manifest-path rust/Cargo.toml -- --checkcargo test --locked --manifest-path rust/Cargo.toml(52 tests passed)RUSTFLAGS="-D warnings" cargo clippy --locked --manifest-path rust/Cargo.tomlFollow-up to #2992; related to #2943.