Bump net-protocol from 0.2.2 to 0.3.0 - #3106
Merged
Merged
Conversation
ruby-head now ships a net/http that calls net-protocol's readuntil(limit:), which needs 0.3.0. Our lock pinned 0.2.2 and it shadowed ruby-head's default gem, breaking the Net::HTTP stdlib tests: https://github.com/ruby/rbs/actions/runs/33056526924/job/98464589988 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test (head, stdlib_test rubocop)fails on ruby-head with 8 errors, all in Net::HTTP / open-uri (run):Cause
ruby/net-http#325 (in ruby/ruby as ruby/ruby@331568b2a) made
Net::HTTPResponseusereaduntil(limit:), which requires net-protocol >= 0.3.0.ruby-head ships 0.3.0 as a default gem, so it is consistent on its own. But
net/httpis a default gem too, so its dependency never reaches Bundler's resolution — our lock pinned 0.2.2 throughnet-smtp, which carries no lower bound, and the installed 0.2.2 shadowed ruby-head's 0.3.0.🤖 Generated with Claude Code