Skip to content

Preserve caller SSL context options when starting SMTP #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 2 commits into
base: master
Choose a base branch
from
+12 −1
Open

Preserve caller SSL context options when starting SMTP #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc1d155
Preserve caller SSL context options when starting SMTP
OskarEichler Aug 27, 2026
1b7e49a
Add regression coverage for preserve caller ssl context options when …
OskarEichler Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/net/smtp.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,7 @@ def start(*args, helo: nil, user: nil, secret: nil, password: nil, authtype: nil
secret ||= password || args[2]
authtype ||= args[3]
if defined?(OpenSSL::VERSION)
ssl_context_params = @ssl_context_params || {}
ssl_context_params = @ssl_context_params&.dup || {}
unless ssl_context_params.has_key?(:verify_mode)
ssl_context_params[:verify_mode] = @tls_verify ? OpenSSL::SSL::VERIFY_PEER : OpenSSL::SSL::VERIFY_NONE
end
Expand Down
11 changes: 11 additions & 0 deletions test/net/smtp/test_sslcontext.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,5 +222,16 @@ def test_ssl_context_params_after_initialize
smtp.start
assert_equal(123, smtp.__ssl_context.timeout)
end

def test_frozen_ssl_context_params
params = {}.freeze
smtp = SMTP.new("example.invalid", starttls: false)
smtp.ssl_context_params = params
smtp.define_singleton_method(:do_start) { |*| @started = true }
smtp.define_singleton_method(:do_finish) { @started = false }

assert_equal :started, smtp.start { :started }
assert_equal({}, params)
end
end
end