Initialize SMTP exception messages through the superclass - #103
Open
OskarEichler wants to merge 2 commits into
Open
Initialize SMTP exception messages through the superclass#103OskarEichler wants to merge 2 commits into
OskarEichler wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Initialize the superclass exception message and use standard Exception rendering/copy behavior. SMTP errors currently override message without initializing Exception, so to_s loses the message and exception("replacement") continues returning the old message.
Reproduction
Verification
rake test: 95 tests, 170 assertions, zero failures/errors, on baseline and this isolated branch, Ruby 4.0.6 via rbenv. Existing local TLS cases are included.git diff --checkpass. No new/modified repository tests, dependencies or workflow settings.c2e9102e1f199a5a10e5261a776d752e64cc130f; runtime matches released 0.5.1. External focused checks were used under the consumer repository's no-new-tests policy.Compatibility and limits
The required response argument and message: keyword remain unchanged; this does not reopen the zero-argument constructor policy in closed #48. Related merged #42 added String construction. Intentional corrections: to_s now shows the message and exception(replacement) honors replacement. The default response message is captured at construction rather than re-read after later mutation of the response. Other Ruby/OS runtimes were not run locally. No production or external SMTP delivery was used. Maintainer CI status is separate from these local checks.