Skip to content

Reject nested SMTP starts before entering session cleanup #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Reject nested SMTP starts before entering session cleanup #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c195322
Reject nested SMTP starts before entering session cleanup
OskarEichler Aug 27, 2026
65d1283
Add regression coverage for reject nested smtp starts before entering…
OskarEichler Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/net/smtp.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,6 +621,7 @@ def started?
#
def start(*args, helo: nil, user: nil, secret: nil, password: nil, authtype: nil)
raise ArgumentError, "wrong number of arguments (given #{args.size}, expected 0..4)" if args.size > 4
raise IOError, 'SMTP session already started' if @started
helo ||= args[0] || 'localhost'
user ||= args[1]
secret ||= password || args[2]
Expand Down Expand Up @@ -664,7 +665,6 @@ def tcp_socket(address, port)
end

def do_start(helo_domain, user, secret, authtype)
raise IOError, 'SMTP session already started' if @started
if user || secret || authtype
check_auth_args authtype, user, secret
end
Expand Down
14 changes: 14 additions & 0 deletions test/net/smtp/test_smtp.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,20 @@ def test_start_instance
smtp.finish
end

def test_nested_block_start_preserves_active_session
server = FakeServer.start
smtp = Net::SMTP.start("localhost", server.port)

error = assert_raise(IOError) do
smtp.start { flunk("nested start must not yield") }
end
assert_equal "SMTP session already started", error.message
assert smtp.started?
assert smtp.rset.success?
ensure
smtp.finish if smtp&.started?
end

def test_start_instance_with_position_argument
port = fake_server_start(auth: 'plain')
smtp = Net::SMTP.new('localhost', port)
Expand Down