Preserve returned read buffer ownership - #72
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BufferedIO appends a String returned by read_nonblock and then clears that returned object. A custom/nonstandard IO that retains the returned String observes unexpected caller-side mutation, even though BufferedIO only needs its copied bytes. Removing the redundant clear preserves ownership and output.
The external ownership model fails on current master and passes after this change on Ruby 4.0.6 and 3.2.11. The unchanged suite passes 30 tests / 66 assertions on both Rubies; syntax and diff checks pass. No repository tests were changed.