Honor JRuby raw mode options - #155
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward
min:,time:andintr:through JRuby's mutating raw-mode paths, preserve fractional timeout conversion, acceptmin: nil, and return the receiver fromraw!.Reproduction
Focused external FFI/stty models show that current
raw!discards every option, truncates fractional timeout before converting to deciseconds, and returns backend state rather than the IO receiver.Verification
Compatibility
Matches MRI's existing option and return contracts. JRuby was modeled but is unavailable locally; current upstream CI is green on JRuby. Prepared with AI-assisted source review; no repository tests were changed.