Preserve reentrant lock state after invalid release - #1112
Open
OskarEichler wants to merge 2 commits into
Open
Conversation
Author
|
Yes. I added regression coverage for both read and write releases. Each test first performs an invalid release, verifies IllegalOperationError, and then acquires and releases the same lock successfully; before this fix, the invalid release mutated the per-thread held count and the later acquire failed. The focused lock spec passes: 41 examples, 0 failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks read/write ownership before decrementing the thread-local hold count. Invalid releases still raise, but no longer wrap the counter and poison later valid lock operations.
Verified by focused reentrant lock specs and models; the review composite passes 2,796 examples with no failures.