qtapp: avoid input unit suffix#880
Open
ourairquality wants to merge 1 commit into
Open
Conversation
Avoid bundling a unit suffix onto numerical input boxes. While this helps presentation it frustrates copying values into these boxed. Move the units to the associate box name or help box. Increase the number of decimal places for latitude and longitude from 9 to 14. Attempts to paste a numerical value with more decimal places would fail and this avoids this frustration, up to 14 decimal places. For distances use 4 decimal places more consistently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can see that a lot of effort was put into adding unit suffixes to input boxes, but personally it's frustrating to have to work around them to position a cursor to avoid them, frustrates copy and paste, and it's frustrating and error prone to have to manually copy over a value. The number of decimal places and their validation also frustrates copy and paste, e.g. copy a latitude or longitude with 14 decimal places and it just will not paste into these input boxes where they are defined for 8 or 9 decimal places, can manually count and cut just the expected number of decimal places but that's frustrating. So this is a frustrated removal of all the suffixes, and an increase in the number of decimal places to 14 for latitudes and longitudes and to 4 for many other distances to reduce validation conflicts. Just close this PR if it's not the direction you wish.
Avoid bundling a unit suffix onto numerical input boxes. While this helps presentation it frustrates copying values into these boxed. Move the units to the associate box name or help box.
Increase the number of decimal places for latitude and longitude from 9 to 14. Attempts to paste a numerical value with more decimal places would fail and this avoids this frustration, up to 14 decimal places.
For distances use 4 decimal places more consistently.