Migrate from Flow to TypeScript#669
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gets rid of Flow and switches to TypeScript. This should make it easier to work on the code base, since TypeScript has much better tooling support. It also let us get rid of an annoying Flow+Prettier workaround for type aliases.
I went with JSDoc instead of
.tsfiles, since it was easier, and preserves all workflows in the repo (the code stays valid standard JS) – even with Flow we used their comment syntax instead of their own type annotation syntax.While this kind of task is pretty well suited to LLM:s, I made this PR without any usage of LLM:s. Some of the boring translations were done by this script I threw together: