feat(test): support inline Rstest projects#48
Conversation
|
Warning Review limit reached
Next review available in: 2 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThe change refactors automatic 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@examples/app-react-ssr/src/index.tsx`:
- Around line 1-8: Replace createRoot with React’s hydrateRoot in the browser
entrypoint so the existing server-rendered markup is hydrated rather than
re-rendered. Update the import and invocation in the root-handling block while
preserving the existing App render and root null check.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 3a1771b6-3e9b-4466-916c-4c93684ffd61
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (21)
README.mdexamples/app-react-ssr/package.jsonexamples/app-react-ssr/rstack.config.tsexamples/app-react-ssr/src/App.tsxexamples/app-react-ssr/src/index.tsxexamples/app-react-ssr/tests/dom.test.tsxexamples/app-react-ssr/tests/ssr.test.tsxexamples/app-react-ssr/tsconfig.jsonexamples/documentation/docs/api/_meta.jsonexamples/documentation/docs/api/testing.mdxpackages/rstack/src/config.tspackages/rstack/src/rstestConfig.tspackages/rstack/test/config/define-test-projects-app/custom.tspackages/rstack/test/config/define-test-projects-app/first.tspackages/rstack/test/config/define-test-projects-app/index.test.tspackages/rstack/test/config/define-test-projects-app/rstack.config.tspackages/rstack/test/config/define-test-projects-app/second.tspackages/rstack/test/config/define-test-projects-lib/first.tspackages/rstack/test/config/define-test-projects-lib/index.test.tspackages/rstack/test/config/define-test-projects-lib/rstack.config.tspackages/rstack/test/config/define-test-projects-lib/second.ts
| @@ -0,0 +1,105 @@ | |||
| # Testing | |||
There was a problem hiding this comment.
I will move ths page to Rstack CLI website in the future
This PR allows
define.test()to use Rstest inline projects while preserving automatic inheritance fromdefine.app()ordefine.lib().The shared adapter is resolved once and applied to each inline project unless the project provides its own
extends, while string project entries remain unchanged.It also adds app and library regression coverage, testing documentation, and a React SSR example demonstrating Node.js and happy-dom projects.