fix: normalize config context loaded by jiti - #7
Closed
stormslowly wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
jiti rewrites
__dirnameto a POSIX-style path on Windows (D:/a/project), so a config written ascontext: __dirnamereaches the bundler with forward slashes. rspack keeps that value as the resolver base and emits mixed-separator dependency paths, while watchpack rebuilds incoming OS event paths withpath.join:That is web-infra-dev/rspack#14446: on Windows, file watching stops after the first change.
What
Normalize the
contextfield of the loaded config — every entry when the config is an array — to the native separator, and only when the config went through jiti. A natively loaded config already sees a native__dirname, so it is left untouched.normalizeContextlives insrc/jiti.tsso the whole workaround can be dropped in one place once jiti stops rewriting__dirname.context: 'D:/a/project'on WindowsD:\a\projectD:/a/project(unchanged)