Add tests for SROS2 access control policies (Issue #238) - #604
Open
Aaravanand00 wants to merge 1 commit into
Open
Add tests for SROS2 access control policies (Issue #238)#604Aaravanand00 wants to merge 1 commit into
Aaravanand00 wants to merge 1 commit into
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
Signed-off-by: Aaravanand <aaravanand@gmail.com>
Aaravanand00
force-pushed
the
fix-issue-238-access-control
branch
from
August 2, 2026 07:24
2cdd195 to
07e29f2
Compare
Contributor
Author
|
@fujitatomoya ptal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds negative testing for SROS2 access control policies by ensuring that nodes configured with restricted security policies (DENY rules) correctly fail to communicate.
Key changes include :-
policy_publisher_denied.xmlandpolicy_subscriber_denied.xml) that restrict publishing and subscribing on thechattertopic.sros_artifacts.cmaketo generate cryptographic artifacts for the new/publisher_deniedand/subscriber_deniedenclaves.test_secure_publisher.cppandtest_secure_subscriber.cppto dynamically parse their enclave names fromargvrather than hardcoding them.test_secure_publisher_subscriber.py.into explicitly pass--ros-args --enclaveto both nodes.access_control_testsmatrix inCMakeLists.txtthat pairs authorized nodes with denied nodes and asserts that the subscriber gracefully times out.Fixes #238
Is this user-facing behavior change?
No, these changes are strictly related to internal testing.
Did you use Generative AI?
Yes ai agent was used to assist in scaffolding the test implementations and CMake loops.
Additional Information
The tests have been verified locally (with
SECURITY=ON) and all security/access-control related test timeouts function correctly, ensuring that invalid access attempts are blocked at the middleware level.