[ros2pkg] Template update for compatibility with virtual environments (#1024) - #1025
Open
cortesvitor wants to merge 1 commit into
Open
Conversation
…ament_python template Signed-off-by: João Vítor Carvalho <victorcarvesk@gmail.com>
cortesvitor
force-pushed
the
victorcarvesk/#1024-fix-ament-python-template
branch
from
May 12, 2025 09:41
600b981 to
8ec4f98
Compare
Member
|
As a quick drive-by: this will break on Windows, where there is no |
|
The virtual-environment issue still looks useful, but the current /usr/bin/env solution is not cross-platform. Would maintainers prefer ros2 pkg create to render a platform-specific executable setting, or should this be addressed outside the generated setup.cfg template? I can prepare a tested follow-up once the intended direction is clear. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1024
Add [build] section with dynamic Python shebang in the setup.cfg file (ament_python template) for compatibility with virtual environments.
This change addresses an issue where build tools were incorrectly embedding a static
/usr/bin/python3shebang in generated scripts, forcing the use of the system's Python interpreter. This update ensures the use of the dynamic/usr/bin/env python3shebang, allowing modules installed in virtual environments to be correctly located.