Validate iterable elements in ensure_argument_type - #993
Open
dlanov wants to merge 1 commit into
Open
Conversation
ensure_argument_type accepted iterables without validating that every element was a type. Invalid entries could expose Python's generic isinstance error or be skipped when any() short-circuited after an earlier match. Materialize the iterable once and validate all elements before matching, while preserving existing behavior for valid inputs and empty iterables. Signed-off-by: Dennis Lanov <dennis.lanov@gmail.com>
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #109.
Summary
ensure_argument_type()accepted an iterable for itstypesargument without validating that every element was actually a type.This caused two inconsistent behaviors:
isinstance()errorany()short-circuitedThis change materializes the iterable once and validates every element before performing argument matching.
Existing behavior remains unchanged for:
Testing
python3 -m pytest launch/test/launch/utilities/test_ensure_argument_type.py -qpython3 -m pytest launch/test/launch/utilities -qpython3 -m flake8 --config=/opt/ros/jazzy/lib/python3.12/site-packages/ament_flake8/configuration/ament_flake8.ini launch/launch/utilities/ensure_argument_type_impl.py launch/test/launch/utilities/test_ensure_argument_type.pygit diff --checkResults: