Repository navigation
Conversation
These methods using gVirtualX for pixel -> rgb and rgb -> pixel conversion In ROOT7 all gVirtualX - related methods need to be removed from Core libraries
Methods from TColor will be deprecated and removed in ROOT7
Pixels are only relevant for the TVirtualX instances - therefore change makes it clear where TVirtualX is used
It converts pixel to color number and should replace TColor::GetColor(pixel) method. As in previous methods, TColor method will be deprecated in ROOT7
Replace TColor::GetColor(pixel) calls To be checked why used in REVE
Replace TColor::GetColor(pixel) calls To be checked why used in REVE
While this methods uses gVirtualX - it was moved to TVirtualX and replaced in all places
TColor::GetPixel() forces graphics initialization which is really big overhead and will be removed in ROOT7
It includes application and colors initialisation inside Number2Pixel method
It redirects to gVirtualX method and better should be used directly via gVirtaulX instance. All usage in ROOT already was removed
It configures actual number of color planes and assign callback function which is invoked when color will be updated. Make private and only available for TVirtualX class - just to decouple last dependency between gVirtualX and TColor
Simple callback to update color instance
In all TVirtualX implementations configure colors handler immediately after display is intitialized. Allows "on-the-fly" update colors
TVirtualX has to initialize handler and planes number when calling OpenDisplay This handler invoked when color is changes - in private Allocate() method In ROOT7 one can fully remove TVirtualX usage then
linev
requested review from
bellenot,
dpiparo,
jblomer,
pcanal and
silverweed
as code owners
November 20, 2026 17:12
Test Results 22 files 22 suites 3d 12h 51m 16s ⏱️ Results for commit 6cbe155. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TColorclass has many methods which directly invokes gVirtualX methods.Most of these methods about pixel->RGB and RGB->pixel conversion.
All such static methods moved now to TVirtualX class and used from ROOT classes.
These are:
Correspondent methods in TColor now marked as deprecated and will be removed in ROOT7.
In GUI and GL classes replace all ocasions by new TVirtualX calls.
There is one workaround for keep support of TVirtualX functionality.
TVirtualX need to assign update handler which is called when color instance is changed
This handler assigned immediately after display is initialized.
Functionality is private and only can be accessed by TVirtualX class (declatred as friend).
In ROOT7 one can decide to remove this - while live change of colors only was
crucial for displays with low color resolution.