Repository navigation
[test] Add test for some operator errors in cppyy - #24278
Conversation
guitargeek
left a comment
There was a problem hiding this comment.
LGTM!
Note that 1 + c also is not supported in C++, but 1. + c and c + 1. work.
So one could have also interpreted the issue as a feature request to make this also work from Python. But I agree that testing for an clean error message instead of the wall of text reported in the issue is a very good compromise, given that this addition on the Python side is a niche case. And most importantly: the most explicit case where you add a Python complex with a C++ complex 1.j + c or c + 1.j works perfectly fine!
Test Results 22 files 22 suites 3d 10h 27m 25s ⏱️ Results for commit c0d1060. |
|
/backport to 6.42 |
|
Preparing to backport PR #24278 to branch 6.42 requested by dpiparo |
|
This PR has been backported to branch 6.42: #24286 |
Fixes #17157