Skip to content

[test] Add test for some operator errors in cppyy - #24278

Merged
dpiparo merged 1 commit into
root-project:masterfrom
dpiparo:test_17157
Nov 20, 2026
Merged

dpiparo merged 1 commit into
root-project:masterfrom
dpiparo:test_17157

Conversation

@dpiparo

@dpiparo dpiparo commented Nov 20, 2026

Copy link
Copy Markdown
Member

Fixes #17157

@dpiparo
dpiparo requested a review from guitargeek November 20, 2026 16:22
@dpiparo dpiparo self-assigned this Nov 20, 2026
@dpiparo dpiparo changed the title [test] Add test for #17157 [test] Add test for some operator errors in cppyy Nov 20, 2026
@dpiparo dpiparo added this to the 6.42.00 milestone Nov 20, 2026

@guitargeek guitargeek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Note that 1 + c also is not supported in C++, but 1. + c and c + 1. work.

So one could have also interpreted the issue as a feature request to make this also work from Python. But I agree that testing for an clean error message instead of the wall of text reported in the issue is a very good compromise, given that this addition on the Python side is a niche case. And most importantly: the most explicit case where you add a Python complex with a C++ complex 1.j + c or c + 1.j works perfectly fine!

@github-actions

Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 10h 27m 25s ⏱️
 3 944 tests  3 944 ✅ 0 💤 0 ❌
77 293 runs  77 293 ✅ 0 💤 0 ❌

Results for commit c0d1060.

@dpiparo
dpiparo merged commit f2c4e0b into root-project:master Nov 20, 2026
57 of 63 checks passed
@dpiparo
dpiparo deleted the test_17157 branch November 20, 2026 21:34
@dpiparo

dpiparo commented Nov 20, 2026

Copy link
Copy Markdown
Member Author

/backport to 6.42

@dpiparo dpiparo removed this from the 6.42.00 milestone Nov 20, 2026
@root-project-bot

Copy link
Copy Markdown

Preparing to backport PR #24278 to branch 6.42 requested by dpiparo

@root-project-bot

Copy link
Copy Markdown

This PR has been backported to branch 6.42: #24286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

operator errors in cppyy

3 participants