Repository navigation
[hist] Replace C limit macros with std::numeric_limits - #24273
Merged
Merged
Conversation
philippe554
requested review from
dpiparo,
guitargeek,
hageboeck and
silverweed
as code owners
November 20, 2026 14:45
philippe554
force-pushed
the
hist-numeric-limits
branch
from
November 20, 2026 15:08
c6498ff to
6e859e1
Compare
Test Results 22 files 22 suites 3d 12h 22m 13s ⏱️ Results for commit 6e859e1. |
guitargeek
approved these changes
Nov 20, 2026
guitargeek
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for this contribution Philippe
Contributor
|
/backport to 6.42 |
|
Preparing to backport PR #24273 to branch 6.42 requested by guitargeek |
|
This PR has been backported to branch 6.42: #24284 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Modernize C numeric limit macros in
histto usestd::numeric_limits.Changes or fixes:
FLT_MAX,INT_MAX,LLONG_MAX, andUINT_MAXwithstd::numeric_limits<...>::max()acrosshist/(TH1.h,TH1.cxx,TH2.cxx,TH3.cxx,THLimitsFinder.cxx,TSpectrum2Painter.cxx) andtutorials/hist/hist103_THnSparse_hist.C.#include <limits>whereverstd::numeric_limitsis used.<cfloat>/<climits>includes in place to avoid breaking downstream code relying on transitive includes, and left documentation/comments unchanged.Checklist:
histbuild andctestpass)