Repository navigation
[RF] Remove cloneAndOwnDataHist() methods of RooHistPdf and RooHistFunc - #24216
Open
guitargeek wants to merge 2 commits into
Open
guitargeek wants to merge 2 commits into
guitargeek wants to merge 2 commits into
Conversation
guitargeek
force-pushed
the
clone-and-own
branch
from
November 17, 2026 22:51
0ed792d to
5309414
Compare
Test Results 22 files 22 suites 3d 9h 41m 3s ⏱️ Results for commit 5309414. |
The `RooHistFunc::cloneAndOwnDataHist()` and `RooHistPdf::cloneAndOwnDataHist()` were removed without deprecation period. They were only introduced in ROOT 6.28 by root-project#12029 and are redundant with the `RooHistFunc` and `RooHistPdf` constructors that take a `std::unique_ptr<RooDataHist>`, introduced also in 6.28. This removal is keep the RooFit API surface under control.
guitargeek
force-pushed
the
clone-and-own
branch
from
November 21, 2026 13:40
5309414 to
dc82bd1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
RooHistFunc::cloneAndOwnDataHist()andRooHistPdf::cloneAndOwnDataHist()were removed without deprecation period. They were only introduced in ROOT 6.28 by #12029 and are redundant with theRooHistFuncandRooHistPdfconstructors that take astd::unique_ptr<RooDataHist>, introduced also in 6.28.This removal is keep the RooFit API surface under control.
Also remove an unused transient data member.