Skip to content

[RF] Remove cloneAndOwnDataHist() methods of RooHistPdf and RooHistFunc - #24216

Open
guitargeek wants to merge 2 commits into
root-project:masterfrom
guitargeek:clone-and-own
Open

guitargeek wants to merge 2 commits into
root-project:masterfrom
guitargeek:clone-and-own

Conversation

@guitargeek

Copy link
Copy Markdown
Contributor

The RooHistFunc::cloneAndOwnDataHist() and RooHistPdf::cloneAndOwnDataHist() were removed without deprecation period. They were only introduced in ROOT 6.28 by #12029 and are redundant with the RooHistFunc and RooHistPdf constructors that take a std::unique_ptr<RooDataHist>, introduced also in 6.28.

This removal is keep the RooFit API surface under control.

Also remove an unused transient data member.

@github-actions

Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 9h 41m 3s ⏱️
 3 886 tests  3 886 ✅ 0 💤 0 ❌
76 071 runs  76 071 ✅ 0 💤 0 ❌

Results for commit 5309414.

The `RooHistFunc::cloneAndOwnDataHist()` and
`RooHistPdf::cloneAndOwnDataHist()` were removed without deprecation
period. They were only introduced in ROOT 6.28 by root-project#12029 and are
redundant with the `RooHistFunc` and `RooHistPdf` constructors that take
a `std::unique_ptr<RooDataHist>`, introduced also in 6.28.

This removal is keep the RooFit API surface under control.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant